Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from nodejs:main #313

Merged
merged 4 commits into from
Nov 15, 2023
Merged

[pull] main from nodejs:main #313

merged 4 commits into from
Nov 15, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Nov 15, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

ovflowd and others added 4 commits November 15, 2023 16:59
* feat: Added Navbar component

* style: Use CSS Module

* fix: Resolve Issues
- Pass Navigation Items as Props
- Remove ThemeProvider as Decorator from Storybook
- Duplicate Images to use in  Light and Dark Theme

* chore: Remove Unused Export

* chore: Pass Required Items as Props

* fix: Change LanguageDropDown's Current Language Prop type to string

* fix: Resolve Issues
- Use BasePath with Image URL
- Pass Proper Namw with Proper Order in Storybook NavItems args
- Create Mobie View

* fix: Resolve Issues
- Use Radix Label
- Rename Menu State
- Use map for Nav Interaction Icons

* fix: Create and Use Github Icon component

* fix: Update SVG Component Props

* chore: Convert SVG to Components

* fix: CSS Indentation

* fix: Use Meaningful Classname

* fix: CSS Indentation

* fix: Resolve Issues
- Fix CSS Indentation
- Move Inline Class to CSS File
- Import Type Imports Separately
- Remove button as Child of anchor tag

* fix: Move NavigationBar into Containers Folder

* feat: Make NavigatioBar a Client Component

* fix: Resolve Issues
- Set Cursor to Pointer on Mobile Item Toggler Label
- Remove NavigationBar Dependency on Current NavItem

* fix: Use CamelCase for Attribute Name

* fix: Remove CurrentPath Arg from Strorybook

* fix: Item Layout When Screen Size is Changed

* fix: Add Nodejs Github Aria Label
* refactor: remove unnecessary hook

* fix: promisify instead of ignoring

* Update util/getBitness.ts

Co-authored-by: canerakdas <canerakdas@gmail.com>
Signed-off-by: Claudio W <cwunder@gnome.org>

---------

Signed-off-by: Claudio W <cwunder@gnome.org>
Co-authored-by: canerakdas <canerakdas@gmail.com>
* feat: ProgressionSidebar component

* fix: safari content-fit not working as expected

* refactor: review updates

* refactor: revert pseudo notation

* refactor: pseudo class and content added

* refactor: self review

* refactor: review updates
@pull pull bot added the ⤵️ pull label Nov 15, 2023
@pull pull bot merged commit 8aace7d into NOUIY:main Nov 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants