-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update comments, remove some temp code, add status "lights" #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried things that didn't work. This branch is non functional. |
marcus-j-davies
added a commit
that referenced
this pull request
Jan 12, 2023
marcus-j-davies
added a commit
that referenced
this pull request
Jan 13, 2023
* Update Deps, Fix Duplicated Cams (hopefully), 2 new events (Boiler plate) * Cleanup + Add Alarm * Small typo * Renew Package lock and small bump to WS type * Keep it pretty! * Address comment #1 * Add Event slit * Add topic (Camera Name) * Small optimisation
marcus-j-davies
added a commit
that referenced
this pull request
May 30, 2023
* Add a new `unifi-protect` node (#48) * Update publish to use Node 14 (#50) * Update package.json * Beta 2 (Dev 1) (#53) * Update Deps, Fix Duplicated Cams (hopefully), 2 new events (Boiler plate) * Cleanup + Add Alarm * Small typo * Renew Package lock and small bump to WS type * Keep it pretty! * Address comment #1 * Add Event slit * Add topic (Camera Name) * Small optimisation * Improve protect status (#56) * Add better status logic * Fix status logic * Add custom port for WS * Dev 2 * Update package.json --------- Co-authored-by: Tadeusz Wyrzykowski <shaquu@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds status lights. Changes some "send" to "warn". Cleans up temporary JSON cookie. Update comments.