Skip to content

Commit

Permalink
post release io changes
Browse files Browse the repository at this point in the history
  • Loading branch information
xuanluo113 committed Oct 4, 2021
1 parent 2ad6731 commit 1f16ee7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 22 deletions.
2 changes: 0 additions & 2 deletions idd/Energy+.idd.in
Original file line number Diff line number Diff line change
Expand Up @@ -5129,10 +5129,8 @@ WindowMaterial:SimpleGlazingSystem,
N1 , \field U-Factor
\required-field
\note Enter U-Factor including film coefficients
\note Note that the effective upper limit for U-factor is 5.8 W/m2-K
\units W/m2-K
\minimum> 0
\maximum 7
N2 , \field Solar Heat Gain Coefficient
\required-field
\note SHGC at Normal Incidence
Expand Down
24 changes: 4 additions & 20 deletions src/EnergyPlus/WindowManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7365,14 +7365,9 @@ namespace WindowManager {
// Write Descriptions
print(state.files.eio,
"{}\n",
"! <WindowConstruction>,Construction Name,Index,#Layers,Roughness,Conductance {W/m2-K},SHGC,"
"! <WindowConstruction>,Construction Name,Index,#Layers,Roughness,Conductance {W/m2-K},Conductance (Before Adjusted) {W/m2-K},"
"Convection Coefficient Adjustment Ratio,SHGC,"
"Solar Transmittance at Normal Incidence,Visible Transmittance at Normal Incidence");
// todo - hold off for bug fix release
// print(state.files.eio,
// "{}\n",
// "! <WindowConstruction>,Construction Name,Index,#Layers,Roughness,Conductance {W/m2-K},Conductance (Before Adjusted)
// {W/m2-K}," "Convection Coefficient Adjustment Ratio,SHGC," "Solar Transmittance at Normal Incidence,Visible
// Transmittance at Normal Incidence");
if ((state.dataHeatBal->TotSimpleWindow > 0) || (state.dataHeatBal->W5GlsMat > 0) || (state.dataHeatBal->W5GlsMatAlt > 0))
print(state.files.eio,
"{}\n",
Expand Down Expand Up @@ -7539,22 +7534,11 @@ namespace WindowManager {
state.dataConstruction->Construct(ThisNum).TotLayers,
Roughness(static_cast<int>(state.dataConstruction->Construct(ThisNum).OutsideRoughness)),
NominalConductanceWinter,
state.dataHeatBal->NominalUBeforeAdjusted(ThisNum),
state.dataHeatBal->CoeffAdjRatio(ThisNum),
SHGCSummer,
TransSolNorm,
TransVisNorm);
// todo
// print(state.files.eio,
// Format_700,
// state.dataConstruction->Construct(ThisNum).Name,
// ThisNum,
// state.dataConstruction->Construct(ThisNum).TotLayers,
// Roughness(static_cast<int>(state.dataConstruction->Construct(ThisNum).OutsideRoughness)),
// NominalConductanceWinter,
// state.dataHeatBal->NominalUBeforeAdjusted(ThisNum),
// state.dataHeatBal->CoeffAdjRatio(ThisNum),
// SHGCSummer,
// TransSolNorm,
// TransVisNorm);
}
// Write(OutputFileConstrainParams, 705) TRIM(Construct(ThisNum)%Name), SHGCSummer ,TransVisNorm

Expand Down

5 comments on commit 1f16ee7

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple-glazing-follow-up (xuanluo113) - Win64-Windows-10-VisualStudio-16: OK (2423 of 2423 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple-glazing-follow-up (xuanluo113) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3218 of 3218 tests passed, 248 test warnings)

Messages:\n

  • 248 tests had: EIO diffs.

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple-glazing-follow-up (xuanluo113) - x86_64-MacOS-10.15-clang-11.0.0: OK (3177 of 3177 tests passed, 246 test warnings)

Messages:\n

  • 246 tests had: EIO diffs.

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple-glazing-follow-up (xuanluo113) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1710 of 1710 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple-glazing-follow-up (xuanluo113) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (734 of 737 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 734
  • Timeout: 3

Build Badge Test Badge Coverage Badge

Please sign in to comment.