Skip to content

Commit

Permalink
Trigger oscillation variables if PerformancePrecision object is present.
Browse files Browse the repository at this point in the history
  • Loading branch information
JasonGlazer committed Mar 2, 2020
1 parent 9fafcb8 commit 2ab0ae1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/EnergyPlus/SimulationManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1204,6 +1204,7 @@ namespace SimulationManager {
bool overrideMinNumWarmupDays(false);
bool overrideBeginEnvResetSuppress(false);
bool overrideMaxZoneTempDiff(false);
ZoneTempPredictorCorrector::OscillationVariablesNeeded = true;
if (fields.find("override_mode") != fields.end()) {
overrideModeValue = UtilityRoutines::MakeUPPERCase(fields.at("override_mode"));
if (overrideModeValue == "NORMAL") {
Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/ZoneTempPredictorCorrector.cc
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ namespace ZoneTempPredictorCorrector {
// This is purposefully in an anonymous namespace so nothing outside this implementation file can use it.
bool InitZoneAirSetPointsOneTimeFlag(true);
bool SetupOscillationOutputFlag(true);
bool OscillationVariablesNeeded(false);
} // namespace
Array1D<Real64> ZoneSetPointLast;
Array1D<Real64> TempIndZnLd;
Expand All @@ -277,6 +276,7 @@ namespace ZoneTempPredictorCorrector {
Real64 AnnualAnyZoneTempOscillate(0.0);
Real64 AnnualAnyZoneTempOscillateDuringOccupancy(0.0);
Real64 AnnualAnyZoneTempOscillateInDeadband(0.0);
bool OscillationVariablesNeeded(false);


// SUBROUTINE SPECIFICATIONS:
Expand Down
1 change: 1 addition & 0 deletions src/EnergyPlus/ZoneTempPredictorCorrector.hh
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ namespace ZoneTempPredictorCorrector {
extern Real64 AnnualAnyZoneTempOscillate;
extern Real64 AnnualAnyZoneTempOscillateDuringOccupancy;
extern Real64 AnnualAnyZoneTempOscillateInDeadband;
extern bool OscillationVariablesNeeded;

// SUBROUTINE SPECIFICATIONS:

Expand Down

7 comments on commit 2ab0ae1

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PerfOverride_Part2 (JasonGlazer) - Win64-Windows-10-VisualStudio-16: OK (2697 of 2697 tests passed, 687 test warnings)

Messages:\n

  • 687 tests had: AUD diffs.
  • 673 tests had: RDD diffs.
  • 13 tests had: MTD diffs.

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PerfOverride_Part2 (JasonGlazer) - x86_64-MacOS-10.13-clang: OK (2701 of 2701 tests passed, 687 test warnings)

Messages:\n

  • 687 tests had: AUD diffs.
  • 673 tests had: RDD diffs.
  • 13 tests had: MTD diffs.

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PerfOverride_Part2 (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PerfOverride_Part2 (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (11 of 11 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PerfOverride_Part2 (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2733 of 2733 tests passed, 691 test warnings)

Messages:\n

  • 691 tests had: AUD diffs.
  • 677 tests had: RDD diffs.
  • 13 tests had: MTD diffs.

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PerfOverride_Part2 (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1313 of 1313 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PerfOverride_Part2 (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (693 of 694 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 693
  • Timeout: 1

Build Badge Test Badge Coverage Badge

Please sign in to comment.