10065 Backed Out One Incorrent Mod

After further review of the code and the concepts of minPLR and frac, I realized that this one change was not consistent with the concept and the change was a mistake on my part. This backs out this change and corrects the unit test as well. Now this is PR ready.
NREL · Jul 31, 2024 · 2c6c557 · 2c6c557 · nrel-bot-2 · Jul 31, 2024
1 parent 3141020
commit 2c6c557
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/EnergyPlus/PlantCentralGSHP.cc b/src/EnergyPlus/PlantCentralGSHP.cc
@@ -2749,7 +2749,7 @@ void WrapperSpecs::calcPLRAndCyclingRatio(EnergyPlusData &state,
     state.dataPlantCentralGSHP->ChillerPartLoadRatio = actualPartLoadRatio;
 
     // Calculate the load due to false loading on chiller over and above water side load
-    state.dataPlantCentralGSHP->ChillerFalseLoadRate = (availChillerCap * minPartLoadRatio) - qEvaporator;
+    state.dataPlantCentralGSHP->ChillerFalseLoadRate = (availChillerCap * actualPartLoadRatio * frac) - qEvaporator;
     if (state.dataPlantCentralGSHP->ChillerFalseLoadRate < HVAC::SmallLoad) {
         state.dataPlantCentralGSHP->ChillerFalseLoadRate = 0.0;
     }

diff --git a/tst/EnergyPlus/unit/PlantCentralGSHP.unit.cc b/tst/EnergyPlus/unit/PlantCentralGSHP.unit.cc
@@ -719,7 +719,7 @@ TEST_F(EnergyPlusFixture, Test_CentralHeatPumpSystem_calcPLRAndCyclingRatio)
     frac = -1.0;
     expPLR = 0.4;
     expFrac = 0.5;
-    expFalseLoad = 10000.0;
+    expFalseLoad = 0.0;
     state->dataPlantCentralGSHP->ChillerCyclingRatio = -1.0;
     state->dataPlantCentralGSHP->ChillerPartLoadRatio = -1.0;
     state->dataPlantCentralGSHP->ChillerFalseLoadRate = -1.0;