Skip to content

Commit

Permalink
Address a couple of review comments from @mjwitte
Browse files Browse the repository at this point in the history
  • Loading branch information
@jmarrec
jmarrec committed Feb 3, 2020
1 parent f90bfea commit 36bd6bd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions idd/Energy+.idd.in
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72568,7 +72568,7 @@ CoolingTower:VariableSpeed:Merkel,
N6 , \field Design Water Flow Rate per Unit of Nominal Capacity
\note This field is only used if the previous is set to autocalculate and performance input method is NominalCapacity
\units m3/s-W
\ip-units gal/min-W
\ip-units (gal/min)/(Btu/h)
\default 5.382E-8
\type real
N7 , \field Design Air Flow Rate
Expand Down Expand Up @@ -88967,7 +88967,7 @@ FaultModel:Fouling:AirFilter,
\key Fan:OnOff
\key Fan:ConstantVolume
\key Fan:VariableVolume
\key Fan:SystemModel
\note Support for Fan:SystemModel is pending
A3, \field Fan Name
\note Enter the name of a fan object
\required-field
Expand Down

7 comments on commit 36bd6bd

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7697_FanSystemModel_IDD (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2659 of 2659 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7697_FanSystemModel_IDD (jmarrec) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (11 of 11 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7697_FanSystemModel_IDD (jmarrec) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7697_FanSystemModel_IDD (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1271 of 1271 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7697_FanSystemModel_IDD (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (677 of 678 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 677
  • Timeout: 1

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7697_FanSystemModel_IDD (jmarrec) - Win64-Windows-10-VisualStudio-16: OK (2619 of 2619 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7697_FanSystemModel_IDD (jmarrec) - x86_64-MacOS-10.13-clang: Build Failed

Build Badge Test Badge

Please sign in to comment.