Skip to content

Commit

Permalink
Remove AirTerminal:SingleDuct:Uncontrolled - fix HVACTemplate const v…
Browse files Browse the repository at this point in the history 
…olume
  • Loading branch information
@mjwitte
mjwitte committed Oct 10, 2019
1 parent 748b978 commit 40f3ae7
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions src/ExpandObjects/epfilter.f90
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18667,9 +18667,7 @@ SUBROUTINE CreateNewConstVol
CALL AddToObjStr('Maximum Hot Water or Steam Flow Rate {m3/s} ','autosize')
CALL AddToObjStr('Minimum Hot Water or Steam Flow Rate {m3/s} ','0')
CALL AddToObjStr('Convergence Tolerance','0.001')
CALL AddToObjFld('Maximum Reheat Air Temperature', base + cvzMaxReheatAirTempOff,' ')
CALL AddToObjStr('Design Specification Outdoor Air Object Name', '')
CALL AddToObjStr('Per Person Ventilation Rate Mode', '',.TRUE.)
CALL AddToObjFld('Maximum Reheat Air Temperature', base + cvzMaxReheatAirTempOff,' ',.TRUE.)
!COIL:Water:SimpleHeating ~ line 104
CALL CreateNewObj('Coil:Heating:Water')
CALL AddToObjFld('Name', base + cvzNameOff,' Reheat Coil')
Expand Down Expand Up @@ -18708,9 +18706,7 @@ SUBROUTINE CreateNewConstVol
CALL AddToObjStr('Maximum Hot Water or Steam Flow Rate {m3/s}','')
CALL AddToObjStr('Minimum Hot Water or Steam Flow Rate {m3/s}','')
CALL AddToObjStr('Convergence Tolerance','0.001')
CALL AddToObjFld('Maximum Reheat Air Temperature', base + cvzMaxReheatAirTempOff,' ')
CALL AddToObjStr('Design Specification Outdoor Air Object Name', '')
CALL AddToObjStr('Per Person Ventilation Rate Mode', '',.TRUE.)
CALL AddToObjFld('Maximum Reheat Air Temperature', base + cvzMaxReheatAirTempOff,' ',.TRUE.)
!COIL:Electric:Heating ~ line 139
CALL CreateNewObj('Coil:Heating:Electric')
CALL AddToObjFld('Name', base + cvzNameOff,' Reheat Coil')
Expand All @@ -18731,9 +18727,7 @@ SUBROUTINE CreateNewConstVol
CALL AddToObjStr('Maximum Hot Water or Steam Flow Rate {m3/s}','')
CALL AddToObjStr('Minimum Hot Water or Steam Flow Rate {m3/s}','')
CALL AddToObjStr('Convergence Tolerance','0.001')
CALL AddToObjFld('Maximum Reheat Air Temperature', base + cvzMaxReheatAirTempOff,' ')
CALL AddToObjStr('Design Specification Outdoor Air Object Name', '')
CALL AddToObjStr('Per Person Ventilation Rate Mode', '',.TRUE.)
CALL AddToObjFld('Maximum Reheat Air Temperature', base + cvzMaxReheatAirTempOff,' ',.TRUE.)
!Coil:Heating:Fuel
CALL CreateNewObj('Coil:Heating:Fuel')
CALL AddToObjFld('Name', base + cvzNameOff,' Reheat Coil')
Expand Down

6 comments on commit 40f3ae7

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeAirTermSDUncontrolled (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2578 of 2619 tests passed, 142 test warnings)

Messages:\n

  • 172 tests had: AUD diffs.
  • 172 tests had: BND diffs.
  • 183 tests had: EIO diffs.
  • 158 tests had: RDD diffs.
  • 16 tests had: ESO small diffs.
  • 30 tests had: MTD diffs.
  • 17 tests had: MTR small diffs.
  • 15 tests had: Table small diffs.
  • 36 tests had: ESO big diffs.
  • 27 tests had: MTR big diffs.
  • 34 tests had: Table big diffs.
  • 5 tests had: ERR diffs.
  • 5 tests had: EDD diffs.
  • 1 test had: MDD diffs.

Failures:\n

regression Test Summary

  • Passed: 648
  • Failed: 41

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeAirTermSDUncontrolled (mjwitte) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (11 of 11 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeAirTermSDUncontrolled (mjwitte) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeAirTermSDUncontrolled (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1239 of 1239 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeAirTermSDUncontrolled (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (674 of 674 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeAirTermSDUncontrolled (mjwitte) - Win64-Windows-10-VisualStudio-16: OK (2538 of 2579 tests passed, 142 test warnings)

Messages:\n

  • 172 tests had: AUD diffs.
  • 172 tests had: BND diffs.
  • 183 tests had: EIO diffs.
  • 158 tests had: RDD diffs.
  • 16 tests had: ESO small diffs.
  • 30 tests had: MTD diffs.
  • 17 tests had: MTR small diffs.
  • 15 tests had: Table small diffs.
  • 27 tests had: MTR big diffs.
  • 34 tests had: Table big diffs.
  • 36 tests had: ESO big diffs.
  • 5 tests had: ERR diffs.
  • 5 tests had: EDD diffs.
  • 1 test had: MDD diffs.

Failures:\n

regression Test Summary

  • Passed: 628
  • Failed: 41

Build Badge Test Badge

Please sign in to comment.