Skip to content

Commit

Permalink
Update Airloop exhaust system and zone exhaust equipment calls.
Browse files Browse the repository at this point in the history
  • Loading branch information
jcyuan2020 committed Dec 3, 2021
1 parent a6dde59 commit 44fabb6
Showing 1 changed file with 36 additions and 15 deletions.
51 changes: 36 additions & 15 deletions design/FY2021/NFP-Dedicated_Exhaust_Fans.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Dedicated Exhaust System for Flexible Exhausts Configurations

- Original Date: July 30, 2021
- Revised: August 2, 2021, revise and start design
- Revised: Nov 20, 2021,
- Revised: Dec 3, 2021,

## Justification for New Feature ##

Expand Down Expand Up @@ -381,7 +381,33 @@ NA

## Designs ##

### SimExhaustAirSystem() ###
### Air Loop Calling Tree ###

#### getExhaustSystemInput() ####

A function to process the input fields for the AirLoopHVAC:ExhaustSystem object. It will read input information in the exhaust system set and update internal data for the components (such as the central exhaust fan, zone exhaust fans, and exhaust mixers) being read in.

#### SizeExhaustSystemFans() ####

This function will be added to size the central exhaust system fans.

#### SimAirLoopExhaustSystems() ####

This function will be added to simulate the central exhaust system in the airloop. Here, since we choose not to tie a central exhaust system to a particular airloop, in this function it could loop through all the central exhaust systems to do the simulation.

One piece of information that needed exchange from the Zone Equipment calling tree is about the flow conditions from the incoming inlet of the AirLoopHVAC:ExhaustSystem objects. It seems that the

#### AirLoopHVAC:ExhaustSystem data struct ####

This struct definition and declaration will create a new data struct for the AirLoopHVAC:ExhaustSystem object.

When the AirlooopHVAC:ExhaustSystem is on, the central exhaust fan needs to know all of the incoming flows set by the ZoneHVAC:ExhaustSystem objects so that the total flow rate can be set. Therefore the AirloopHVAC:ExhuastSystem objects need to be called before zone equipment to set the AirLoop exhaust system's status for the Zone Equipment exhaust system simulation, which seems to be a natural order of calling.

However, when modeling the central exhasut fans in the airloop, the zone equipment airflow status needs to be feed back to the Air Loop, in order to simulate the exhaust fan flows. This is not a natural order of calling. One additional airloop level exhasut system call need to be added after the zone equipment exhaust module calling.

### Zone Equipment Calling Tree ###

#### SimZoneHVACExhaustAirSystem() ####

A proper simulation entry point for the exhaust system simulation would be after the
```
Expand All @@ -393,23 +419,18 @@ and before the function
```
near the end of the `SimZoneEquipment()` function in ZoneEquipmentManager.cc.

The new `SimExhaustAirSystem()` should be added here to conduct the AirLoopHVAC:ExhaustSystem simulation.

There should also be some airloop level calls (or a new function if needed) about the exhasut air system.

### SizeExhaustSystemFan() ###

This function will be added to size the central exhaust system fans.

### getExhaustSystemInput() ###
The new `SimZoneExhaustAirSystem()` should be added here to conduct the AirLoopHVAC:ExhaustSystem simulation.

A function to process the input fields for the AirLoopHVAC:ExhaustSystem object. It will read input information in the exhaust system set and update internal data for the components (such as the central exhaust fan, zone exhaust fans, and exhaust mixers) being read in.
However, the situation could be complicated by the general exhaust system's operation. Here based on If the AirloopHVAC:ExhaustSystem's condition, (e.g. "is on" or "is off"), the zone air balance will be treated differently. For example, when the AirLoopHVAC:ExhaustSystem is off, all inlet flows for the connected zone exhausts should be set to zero. This needs to be known at the time of the zone air mass balance. A zone mass balance, in this case, the call to the newly adde SimZoneExhaustAirSystem() should be called before the zone mass balance calculation:
```
CalcZoneMassBalance(state, FirstHVACIteration);
```

### AirLoopHVAC:ExhaustSystem data struct ###
#### Modleing AirloopHVAC central exhaust airflow ####

This struct definition and declaration will create a new data struct for the AirLoopHVAC:ExhaustSystem object.
After the zone equipment exhaust systems' airflows are modeled, here the airloop's central airlfow should be modeled (again). This time, the central exhaust fan airflow should be udpated based on the zone exhaust airflows of the connected zone exhaust.

### ZoneHVAC:ExhaustSystem data struct ###
#### ZoneHVAC:ExhaustSystem data struct ####

This struct definition and declaration will create a new data struct for the ZoneHVAC:ExhaustSystem object.

Expand Down

5 comments on commit 44fabb6

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dedicated_Exhaust_System (jcyuan2020) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3217 of 3218 tests passed, 248 test warnings)

Messages:\n

  • 248 tests had: EIO diffs.
  • 1 test had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 752
  • Failed: 1

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dedicated_Exhaust_System (jcyuan2020) - x86_64-MacOS-10.15-clang-11.0.0: OK (3176 of 3177 tests passed, 246 test warnings)

Messages:\n

  • 246 tests had: EIO diffs.
  • 1 test had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 732
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dedicated_Exhaust_System (jcyuan2020) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1710 of 1710 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dedicated_Exhaust_System (jcyuan2020) - Win64-Windows-10-VisualStudio-16: OK (2423 of 2423 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dedicated_Exhaust_System (jcyuan2020) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (737 of 737 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.