Skip to content

Commit

Permalink
remove unused
Browse files Browse the repository at this point in the history
  • Loading branch information
xuanluo113 committed Nov 11, 2020
1 parent 15c8fb9 commit 5c53806
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 10 deletions.
2 changes: 0 additions & 2 deletions src/EnergyPlus/DataSurfaces.cc
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,6 @@ namespace DataSurfaces {
Array1D<Real64> SurfWinBmBmSolar; // Exterior beam-to-beam solar transmitted through window, or window plus blind, into zone (W)
Array1D<Real64> SurfWinBmDifSolar; // Exterior beam-to-diffuse solar transmitted through window, or window plus blind, into zone (W)
Array1D<Real64> SurfWinDifSolar; // Exterior diffuse solar transmitted through window, or window plus shade/blind, into zone (W)
Array1D<Real64> SurfWinDirSolTransAtIncAngle; // Window's beam-beam solar transmittance at current timestep's angle of incidence
Array1D<Real64> SurfWinHeatGain; // Total heat gain from window = WinTransSolar + (IR and convection from glazing, or,
// if interior shade, IR and convection from zone-side of shade plus gap air convection to zone) +
// (IR convection from frame) + (IR and convection from divider if no interior shade) (W)
Expand Down Expand Up @@ -1280,7 +1279,6 @@ namespace DataSurfaces {
SurfWinBmBmSolar.deallocate();
SurfWinBmDifSolar.deallocate();
SurfWinDifSolar.deallocate();
SurfWinDirSolTransAtIncAngle.deallocate();
SurfWinHeatGain.deallocate();
SurfWinHeatTransfer.deallocate();
SurfWinHeatGainRep.deallocate();
Expand Down
1 change: 0 additions & 1 deletion src/EnergyPlus/DataSurfaces.hh
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,6 @@ namespace DataSurfaces {
extern Array1D<Real64> SurfWinBmBmSolar; // Exterior beam-to-beam solar transmitted through window, or window plus blind, into zone (W)
extern Array1D<Real64> SurfWinBmDifSolar; // Exterior beam-to-diffuse solar transmitted through window, or window plus blind, into zone (W)
extern Array1D<Real64> SurfWinDifSolar; // Exterior diffuse solar transmitted through window, or window plus shade/blind, into zone (W)
extern Array1D<Real64> SurfWinDirSolTransAtIncAngle; // Window's beam-beam solar transmittance at current timestep's angle of incidence
extern Array1D<Real64> SurfWinHeatGain; // Total heat gain from window = WinTransSolar + (IR and convection from glazing, or,
// if interior shade, IR and convection from zone-side of shade plus gap air convection to zone) +
// (IR convection from frame) + (IR and convection from divider if no interior shade) (W)
Expand Down
1 change: 0 additions & 1 deletion src/EnergyPlus/HeatBalanceSurfaceManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2557,7 +2557,6 @@ namespace HeatBalanceSurfaceManager {
SurfWinBmBmSolar(SurfNum) = 0.0;
SurfWinBmDifSolar(SurfNum) = 0.0;
SurfWinDifSolar(SurfNum) = 0.0;
SurfWinDirSolTransAtIncAngle(SurfNum) = 0.0;
// energy
SurfWinTransSolarEnergy(SurfNum) = 0.0;
SurfWinBmSolarEnergy(SurfNum) = 0.0;
Expand Down
6 changes: 0 additions & 6 deletions src/EnergyPlus/SolarShading.cc
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ namespace SolarShading {
SurfWinBmBmSolar(SurfNum) = 0.0;
SurfWinBmDifSolar(SurfNum) = 0.0;
SurfWinDifSolar(SurfNum) = 0.0;
SurfWinDirSolTransAtIncAngle(SurfNum) = 0.0;

SurfWinTransSolarEnergy(SurfNum) = 0.0;
SurfWinBmSolarEnergy(SurfNum) = 0.0;
Expand Down Expand Up @@ -803,7 +802,6 @@ namespace SolarShading {
SurfWinBmDifSolar.dimension(TotSurfaces, 0.0);

SurfWinDifSolar.dimension(TotSurfaces, 0.0);
SurfWinDirSolTransAtIncAngle.dimension(TotSurfaces, 0.0);
SurfWinHeatGain.dimension(TotSurfaces, 0.0);
SurfWinHeatTransfer.dimension(TotSurfaces, 0.0);
SurfWinHeatGainRep.dimension(TotSurfaces, 0.0);
Expand Down Expand Up @@ -6245,7 +6243,6 @@ namespace SolarShading {

Array1D<Real64> WinTransBmBmSolar(TotSurfaces); // Factor for exterior beam to beam solar transmitted through window, or window plus shade, into zone at current time (m2)
Array1D<Real64> WinTransBmDifSolar(TotSurfaces); // Factor for exterior beam to diffuse solar transmitted through window, or window plus shade, into zone at current time (m2)
Array1D<Real64> TBmBmAndDif(TotSurfaces);

if (state.dataSolarShading->MustAllocSolarShading) {
DBZoneIntWin.allocate(NumOfZones);
Expand Down Expand Up @@ -8096,7 +8093,6 @@ namespace SolarShading {
} // End of check on complex vs. simple interior solar distribution

} // End of sunlit fraction > 0 test
TBmBmAndDif(SurfNum) = TBmBm + TBmDif;
} // End of first loop over surfaces in zone

BABSZoneSSG = 0.0;
Expand Down Expand Up @@ -8233,8 +8229,6 @@ namespace SolarShading {
SurfWinBmBmSolarEnergy(SurfNum) = SurfWinBmBmSolar(SurfNum) * TimeStepZoneSec;
SurfWinBmDifSolarEnergy(SurfNum) = SurfWinBmDifSolar(SurfNum) * TimeStepZoneSec;

SurfWinDirSolTransAtIncAngle(SurfNum) = TBmBmAndDif(SurfNum); // For TDD:DIFFUSER this is the TDD transmittance

// Solar not added by TDD:DOME; added to zone via TDD:DIFFUSER
if (Surface(SurfNum).Class != SurfaceClass_TDD_Dome) {
ZoneTransSolar(enclosureNum) += SurfWinTransSolar(SurfNum); //[W]
Expand Down

5 comments on commit 5c53806

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix-tdd-solar (xuanluo113) - x86_64-MacOS-10.15-clang-11.0.0: OK (2992 of 2993 tests passed, 0 test warnings)

Messages:\n

  • 1 test had: EIO diffs.
  • 1 test had: ESO big diffs.
  • 1 test had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 716
  • Failed: 1

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix-tdd-solar (xuanluo113) - Win64-Windows-10-VisualStudio-16: OK (2249 of 2249 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix-tdd-solar (xuanluo113) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3031 of 3033 tests passed, 0 test warnings)

Messages:\n

  • 2 tests had: EIO diffs.
  • 1 test had: ESO big diffs.
  • 2 tests had: Table big diffs.
  • 1 test had: ESO small diffs.
  • 1 test had: MTR small diffs.

Failures:\n

regression Test Summary

  • Passed: 735
  • Failed: 2

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix-tdd-solar (xuanluo113) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1557 of 1557 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix-tdd-solar (xuanluo113) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (722 of 722 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.