Merge pull request #10525 from NREL/10355_CompressorRack_WalkIn_InZone

Fix #10355 - Correctly Set up Zone Internal Gains when Refrigeration:CompressorRack serves a Refrigeration:WalkIn object with "Zone" Heat Transfer Location
NREL · May 30, 2024 · 6cccca9 · 6cccca9 · nrel-bot · May 30, 2024
2 parents 1b333b5 + 8bd98c2
commit 6cccca9
Show file tree

Hide file tree

Showing 3 changed files with 758 additions and 2 deletions.
diff --git a/src/EnergyPlus/RefrigeratedCase.cc b/src/EnergyPlus/RefrigeratedCase.cc
@@ -8634,8 +8634,9 @@ void SetupReportInput(EnergyPlusData &state)
                                         OutputProcessor::StoreType::Sum,
                                         rack.Name);
 
+                    // If CoilFlag is true and Location is Zone, GetRefrigerationInput ensures you must have a Heat Rejection Zone provided already
                     SetupZoneInternalGain(state,
-                                          RefrigCase(rack.CaseNum(1)).ActualZoneNum,
+                                          rack.HeatRejectionZoneNum,
                                           rack.Name,
                                           DataHeatBalance::IntGainType::RefrigerationCompressorRack,
                                           &rack.SensZoneCreditHeatRate,
@@ -8794,8 +8795,18 @@ void SetupReportInput(EnergyPlusData &state)
                                         OutputProcessor::TimeStepType::Zone,
                                         OutputProcessor::StoreType::Sum,
                                         rack.Name);
+
+                    // if Location is Zone, GetRefrigerationInputEither checks that you have at least one load and that either:
+                    // * You have only cases, and they must be all in the same zone
+                    // * Or you must have a Heat Rejection Zone provided
+                    int rackZoneNum = -1;
+                    if (rack.HeatRejectionZoneNum > 0) {
+                        rackZoneNum = rack.HeatRejectionZoneNum;
+                    } else {
+                        rackZoneNum = RefrigCase(rack.CaseNum(1)).ActualZoneNum;
+                    }
                     SetupZoneInternalGain(state,
-                                          RefrigCase(rack.CaseNum(1)).ActualZoneNum,
+                                          rackZoneNum,
                                           rack.Name,
                                           DataHeatBalance::IntGainType::RefrigerationCompressorRack,
                                           &rack.SensZoneCreditHeatRate,

diff --git a/tst/EnergyPlus/unit/CMakeLists.txt b/tst/EnergyPlus/unit/CMakeLists.txt
@@ -197,6 +197,7 @@ set(test_src
     Psychrometrics.unit.cc
     Pumps.unit.cc
     PurchasedAirManager.unit.cc
+    RefrigeratedCase.unit.cc
     ReportCoilSelection.unit.cc
     ResultsFramework.unit.cc
     RoomAirModelUserTempPattern.unit.cc