Skip to content

Commit

Permalink
fix EmmelVertical convection correlation
Browse files Browse the repository at this point in the history
  • Loading branch information
mitchute committed Oct 13, 2021
1 parent 714607d commit 8537c55
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions src/EnergyPlus/ConvectionCoefficients.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8838,25 +8838,24 @@ Real64 CalcEmmelVertical(EnergyPlusData &state,
// REFERENCES:
// Emmel, M.G., M.O. Abadie, N. Mendes. 2007. New external convective
// heat transfer coefficient correlations for isolated low-rise buildings.
// Energy and Buildings 39 (2007) 335- 342
// Energy and Buildings 39 (2007) 335- 342

// Return value
Real64 Hf;

Real64 Theta; // angle between wind and surface azimuth

Theta = WindDir - SurfAzimuth - 90.0; // TODO double check theta
if (Theta > 180.0) Theta -= 360.0;
Theta = CalcWindSurfaceTheta(WindDir, SurfAzimuth);

if (Theta <= 22.5) {
Hf = 5.15 * std::pow(WindAt10m, 0.81);
} else if ((22.5 < Theta) && (Theta <= 67.5)) {
} else if (Theta <= 67.5) {
Hf = 3.34 * std::pow(WindAt10m, 0.84);
} else if ((67.5 < Theta) && (Theta <= 112.5)) {
} else if (Theta <= 112.5) {
Hf = 4.78 * std::pow(WindAt10m, 0.71);
} else if ((112.5 < Theta) && (Theta <= 157.5)) {
} else if (Theta <= 157.5) {
Hf = 4.05 * std::pow(WindAt10m, 0.77);
} else if ((157.5 < Theta) && (Theta <= 180.0)) {
} else if (Theta <= 180.0) {
Hf = 3.54 * std::pow(WindAt10m, 0.76);

} else {
Expand Down

5 comments on commit 8537c55

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emmel_conv (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3220 of 3220 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emmel_conv (mitchute) - Win64-Windows-10-VisualStudio-16: OK (2425 of 2425 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emmel_conv (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1712 of 1712 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emmel_conv (mitchute) - x86_64-MacOS-10.15-clang-11.0.0: OK (3179 of 3179 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emmel_conv (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (737 of 737 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.