Skip to content

Commit

Permalink
Fix #6050 - Do not pass Fan MinAirMassFlowRate (Fan Power Minimum Air…
Browse files Browse the repository at this point in the history 
… Flow Rate) to the outlet node's MassFlowRateMin
  • Loading branch information
@jmarrec
jmarrec committed Dec 2, 2020
1 parent a8d6314 commit 89b2d4f
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/EnergyPlus/Fans.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1107,7 +1107,10 @@ namespace Fans {

// Init the Node Control variables
Node(OutNode).MassFlowRateMax = Fan(FanNum).MaxAirMassFlowRate;
Node(OutNode).MassFlowRateMin = Fan(FanNum).MinAirMassFlowRate;
// According to the IO Ref guide:
// "Note that this field is only used to calculate the fan power.
// This field does not enforce the system air flow rate during simulation"
// Node(OutNode).MassFlowRateMin = Fan(FanNum).MinAirMassFlowRate;

// Initialize all report variables to a known state at beginning of simulation
Fan(FanNum).FanPower = 0.0;
Expand Down

5 comments on commit 89b2d4f

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6050_ReturnFan_MinFlowFrac (jmarrec) - x86_64-MacOS-10.15-clang-11.0.0: OK (2992 of 2995 tests passed, 1 test warnings)

Messages:\n

  • 4 tests had: EIO diffs.
  • 1 test had: Table small diffs.
  • 3 tests had: ESO big diffs.
  • 3 tests had: Table big diffs.
  • 1 test had: ERR diffs.

Failures:\n

regression Test Summary

  • Passed: 714
  • Failed: 3

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6050_ReturnFan_MinFlowFrac (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3031 of 3035 tests passed, 1 test warnings)

Messages:\n

  • 5 tests had: EIO diffs.
  • 1 test had: Table small diffs.
  • 1 test had: ERR diffs.
  • 3 tests had: ESO big diffs.
  • 4 tests had: Table big diffs.
  • 1 test had: ESO small diffs.
  • 1 test had: MTR small diffs.

Failures:\n

regression Test Summary

  • Passed: 733
  • Failed: 4

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6050_ReturnFan_MinFlowFrac (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1559 of 1559 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6050_ReturnFan_MinFlowFrac (jmarrec) - Win64-Windows-10-VisualStudio-16: OK (2251 of 2251 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6050_ReturnFan_MinFlowFrac (jmarrec) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: Coverage Too Low

Build Badge Test Badge Coverage Badge

Please sign in to comment.