Skip to content

Commit

Permalink
Naive try at fixing incorrect ExpandObjects warning
Browse files Browse the repository at this point in the history 
An extra field was added for Boiler:HotWater in #9925

```shell
$ /Applications/EnergyPlus-23-2-0/energyplus -D -d out -x /Applications/EnergyPlus-23-2-0/ExampleFiles/VAVSingleDuctConstFlowBoiler.idf

$ cat out/eplusout.experr
ExpandObjects: SEVERE: Too many fields were found for the object: Boiler:HotWater, Number expected=[17], Number found=[18]
`
``
  • Loading branch information
@jmarrec
jmarrec committed Oct 30, 2023
1 parent d07d7ad commit 9dee65f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/ExpandObjects/epfilter.f90
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1507,7 +1507,7 @@ PROGRAM epfilter
INTEGER,PARAMETER :: blrhwNameOff = 1
INTEGER,PARAMETER :: blrhwInletNodeOff = 11
INTEGER,PARAMETER :: blrhwOutletNodeOff = 12
INTEGER,PARAMETER :: blrhwLastFieldOff = 17
INTEGER,PARAMETER :: blrhwLastFieldOff = 18

! Chiller:Electric:EIR (for use with HVACTemplate:Plant:Chiller:ObjectReference)
INTEGER,PARAMETER :: chleirNameOff = 1
Expand Down Expand Up @@ -2305,7 +2305,7 @@ SUBROUTINE SetUpObjectsToProcess(doGatherSurfaces)
CALL AddObjToProcess('HVACTemplate:Plant:MixedWaterLoop',.TRUE., mwpNameOff, mwpLdDistSchmOff, 17)
CALL AddObjToProcess('HVACTemplate:System:DedicatedOutdoorAir',.TRUE.,doasNameOff, doasHumidSetPtSchedNameOff, 46)
! Detailed Plant Objects
CALL AddObjToProcess('Boiler:HotWater',.FALSE., blrhwOutletNodeOff, blrhwLastFieldOff, 17)
CALL AddObjToProcess('Boiler:HotWater',.FALSE., blrhwOutletNodeOff, blrhwLastFieldOff, 18)
CALL AddObjToProcess('Chiller:Electric:EIR',.FALSE., chleirCondTypeOff, chleirLastFieldOff, 30)
CALL AddObjToProcess('Chiller:Electric:ReformulatedEIR',.FALSE., chlreirCondOutletNodeOff, chlreirLastFieldOff, 26)
CALL AddObjToProcess('CoolingTower:SingleSpeed',.FALSE., twrssOutletNodeOff, twrssLastFieldOff, 29)
Expand Down

5 comments on commit 9dee65f

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExpandObjects_BoilerHotWater (jmarrec) - x86_64-MacOS-10.17-clang-14.0.0: OK (3536 of 3536 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExpandObjects_BoilerHotWater (jmarrec) - Win64-Windows-10-VisualStudio-16: OK (2750 of 2750 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExpandObjects_BoilerHotWater (jmarrec) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3576 of 3577 tests passed, 0 test warnings)

Messages:\n

  • 1 test had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 804
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExpandObjects_BoilerHotWater (jmarrec) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1964 of 1964 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExpandObjects_BoilerHotWater (jmarrec) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (789 of 789 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.