Skip to content

Commit

Permalink
Daylighting output cleanup - more output rules
Browse files Browse the repository at this point in the history
  • Loading branch information
mjwitte committed Nov 4, 2021
1 parent 946c2a6 commit a5f7fb5
Showing 1 changed file with 39 additions and 0 deletions.
39 changes: 39 additions & 0 deletions src/Transition/OutputRulesFiles/OutputChanges9-6-0-to-22-03-0.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,42 @@ Sky Daylight Factors,Clear Sky,01/21,ZN_1_FLR_1_SEC_1_DAYLCTRL,ZN_1_FLR_1_SEC_1,
```

See pull request [#9102](https://github.com/NREL/EnergyPlus/pull/9102/files) for more details.


### DXF Changes for Daylighting Reference Points

The following changes were made to Daylighting reference points in dxf output:
* Duplicate daylighting reference points are removed
* The actual reference point names are used in the label, rather than RefPt1, 2, etc.

See pull request [#9102](https://github.com/NREL/EnergyPlus/pull/9102/files) for more details.

### DFS Changes for Daylighting

For `Output:DaylightFactors`, the daylight factors are now reported by Enclosure instead of by Zone, and Enclosure Name is added as a new field along with Zone Name.
This may alter the order and number of entries.

```
This file contains daylight factors for all exterior windows of daylight zones.
MonthAndDay,Zone Name,Window Name,Window State
Hour,Reference Point,Daylight Factor for Clear Sky,Daylight Factor for Clear Turbid Sky,Daylight Factor for Intermediate Sky,Daylight Factor for Overcast Sky
01/21,PERIMETER_BOT_ZN_1,PERIMETER_BOT_ZN_1_WALL_SOUTH_WINDOW,Base Window
```

are now

```
This file contains daylight factors for all exterior windows of daylight enclosures.
MonthAndDay,Enclosure Name,Zone Name,Window Name,Window State
Hour,Reference Point,Daylight Factor for Clear Sky,Daylight Factor for Clear Turbid Sky,Daylight Factor for Intermediate Sky,Daylight Factor for Overcast Sky
01/21,PERIMETER_BOT_ZN_3,PERIMETER_BOT_ZN_3,PERIMETER_BOT_ZN_3_WALL_NORTH_WINDOW,Base Window
```

See pull request [#9102](https://github.com/NREL/EnergyPlus/pull/9102/files) for more details.

### Row Order Changes for Lighting Summary, Daylighting subtable

The row order may change in this subtable.

See pull request [#9102](https://github.com/NREL/EnergyPlus/pull/9102/files) for more details.

5 comments on commit a5f7fb5

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space-followup (mjwitte) - Win64-Windows-10-VisualStudio-16: OK (2427 of 2427 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space-followup (mjwitte) - x86_64-MacOS-10.15-clang-11.0.0: OK (3174 of 3181 tests passed, 49 test warnings)

Messages:\n

  • 56 tests had: EIO diffs.
  • 52 tests had: DXF diffs.
  • 1 test had: DFS diffs.
  • 7 tests had: Table big diffs.
  • 1 test had: Table small diffs.

Failures:\n

regression Test Summary

  • Passed: 726
  • Failed: 7

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space-followup (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3215 of 3222 tests passed, 51 test warnings)

Messages:\n

  • 57 tests had: EIO diffs.
  • 53 tests had: DXF diffs.
  • 2 tests had: PERF_LOG diffs.
  • 1 test had: DFS diffs.
  • 7 tests had: Table big diffs.
  • 1 test had: Table small diffs.

Failures:\n

regression Test Summary

  • Passed: 746
  • Failed: 7

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space-followup (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1714 of 1714 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space-followup (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (737 of 737 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.