Skip to content

Commit

Permalink
Fix #8524 - Found the needle in the haystack: this from PR #8275 (bri…
Browse files Browse the repository at this point in the history 
…nging in sam / SSC) was permanently overriding every `install()` command and producing an almost empty package

cf https://cmake.org/pipermail/cmake/2017-February/065033.html
  • Loading branch information
@jmarrec
jmarrec committed Feb 11, 2021
1 parent 687fc39 commit d4e2687
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions third_party/ssc/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,9 @@ endfunction()
# turn off examples, tests and install for jsoncpp
set(JSONCPP_WITH_EXAMPLE 0)
set(JSONCPP_WITH_TESTS 0)
macro (install)
endmacro ()
add_subdirectory(jsoncpp)
macro (install)
_install(${ARGV})
endmacro(install)

# Skip install() commands for jsoncpp
add_subdirectory(jsoncpp EXCLUDE_FROM_ALL)

add_subdirectory(splinter)
add_subdirectory(shared)
Expand Down

1 comment on commit d4e2687

@lefticus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSC is also incorrectly disabling all warnings on all compilers for all targets that link to it. I've fixed this in my cmake_modernization branch.

Please sign in to comment.