Skip to content

Commit

Permalink
Address review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
lymereJ committed Apr 2, 2024
1 parent e88cc37 commit d9d5aba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions src/EnergyPlus/DataConvergParams.hh
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ namespace DataConvergParams {
constexpr Real64 PlantEnergyToler(10.0); // Tolerance for Energy comparisons (in Watts W)

// Energy Tolerance Calculation, used to scale the answer for a more intuitive answer for comparison
constexpr Real64 PlantFlowFlowRateToler(0.01); // Tolerance for mass flow rate convergence (in kg/s)
constexpr Real64 PlantLowFlowRateToler(1.0E-30); // Tolerance for low mass flow rate used for determining when plant pumps can be shut down
constexpr Real64 PlantFlowFlowRateToler(0.01); // Tolerance for mass flow rate convergence (in kg/s)

constexpr int ConvergLogStackDepth(10);

Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/Plant/LoopSide.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1175,7 +1175,7 @@ namespace DataPlant {

// overrides the loop solver flow request to allow loop pump to turn off when not in use
if (this_loop_side.TotalPumps == 1) {
if (LoopFlow < DataConvergParams::PlantLowFlowRateToler) { // Update from dataconvergetols...
if (LoopFlow < DataHVACGlobals::VerySmallMassFlow) { // Update from dataconvergetols...
for (int BranchCounter = 1; BranchCounter <= this_loop_side.TotalBranches; ++BranchCounter) {
// reference
auto &branch(this_loop_side.Branch(BranchCounter));
Expand Down

5 comments on commit d9d5aba

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plant_low_flow_tol_update (lymereJ) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3597 of 3597 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plant_low_flow_tol_update (lymereJ) - Win64-Windows-10-VisualStudio-16: OK (2768 of 2768 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plant_low_flow_tol_update (lymereJ) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1980 of 1980 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plant_low_flow_tol_update (lymereJ) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (791 of 791 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plant_low_flow_tol_update (lymereJ) - x86_64-MacOS-10.18-clang-15.0.0: OK (3556 of 3556 tests passed, 0 test warnings)

Build Badge Test Badge

Please sign in to comment.