Skip to content

Commit

Permalink
partial moving HPWH to plantCompPtr
Browse files Browse the repository at this point in the history
  • Loading branch information
mitchute committed Nov 21, 2019
1 parent 00772c3 commit f1d12a3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 36 deletions.
14 changes: 0 additions & 14 deletions src/EnergyPlus/IntegratedHeatPump.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2204,9 +2204,6 @@ namespace IntegratedHeatPump {
using WaterThermalTanks::GetWaterThermalTankInput;

Real64 MyLoad(0.0);
// Real64 MaxCap(0.0);
// Real64 MinCap(0.0);
// Real64 OptCap(0.0);
Real64 WHHeatTimeSav(0.0); // time accumulation for water heating
Real64 WHHeatVolSave(0.0); // volume accumulation for water heating

Expand Down Expand Up @@ -2261,17 +2258,6 @@ namespace IntegratedHeatPump {
PlantLocation A(0, 0, 0, 0);
HPWH.simulate(A, true, MyLoad, true);

// WaterThermalTanks::SimWaterThermalTank_HeatPump(tankType,
// IntegratedHeatPumps(DXCoilNum).WHtankName,
// IntegratedHeatPumps(DXCoilNum).WHtankID,
// false,
// false,
// MyLoad,
// MaxCap,
// MinCap,
// OptCap,
// true);

tank.callerLoopNum = 0;

}
Expand Down
22 changes: 0 additions & 22 deletions src/EnergyPlus/PlantLoopEquip.cc
Original file line number Diff line number Diff line change
Expand Up @@ -637,9 +637,7 @@ namespace PlantLoopEquip {
int tankIDX = WaterThermalTanks::getTankIDX(sim_component.Name, EquipNum);
auto &tank = WaterThermalTanks::WaterThermalTank(tankIDX);
tank.callerLoopNum = LoopNum;

sim_component.compPtr->simulate(sim_component_location, FirstHVACIteration, CurLoad, RunFlag);

tank.callerLoopNum = 0;

// HEAT PUMP WATER HEATER
Expand All @@ -650,29 +648,9 @@ namespace PlantLoopEquip {
int tankIDX = HPWH.WaterHeaterTankNum;
auto &tank = WaterThermalTanks::WaterThermalTank(tankIDX);
tank.callerLoopNum = LoopNum;

sim_component.compPtr->simulate(sim_component_location, FirstHVACIteration, CurLoad, RunFlag);

// SimWaterThermalTank_HeatPump(EquipTypeNum,
// sim_component.Name,
// EquipNum,
// RunFlag,
// InitLoopEquip,
// CurLoad,
// MaxLoad,
// MinLoad,
// OptLoad,
// FirstHVACIteration); // DSU

tank.callerLoopNum = 0;

// if (InitLoopEquip) {
// sim_component.MaxLoad = MaxLoad;
// sim_component.MinLoad = MinLoad;
// sim_component.OptLoad = OptLoad;
// sim_component.CompNum = EquipNum;
// }

} else {
ShowSevereError("SimPlantEquip: Invalid Water Heater Type=" + sim_component.TypeOf);
ShowContinueError("Occurs in Plant Loop=" + PlantLoop(LoopNum).Name);
Expand Down

7 comments on commit f1d12a3

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waterHeaterMixedRefactor (mitchute) - x86_64-MacOS-10.13-clang: OK (2569 of 2581 tests passed, 5 test warnings)

Messages:\n

  • 16 tests had: MTD diffs.
  • 17 tests had: RDD diffs.
  • 9 tests had: EIO diffs.
  • 12 tests had: BND diffs.
  • 12 tests had: MDD diffs.
  • 4 tests had: MTR small diffs.
  • 12 tests had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 657
  • Failed: 12

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waterHeaterMixedRefactor (mitchute) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waterHeaterMixedRefactor (mitchute) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (11 of 11 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waterHeaterMixedRefactor (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2609 of 2621 tests passed, 5 test warnings)

Messages:\n

  • 16 tests had: MTD diffs.
  • 17 tests had: RDD diffs.
  • 9 tests had: EIO diffs.
  • 12 tests had: BND diffs.
  • 12 tests had: MDD diffs.
  • 12 tests had: Table big diffs.
  • 2 tests had: MTR small diffs.

Failures:\n

regression Test Summary

  • Passed: 677
  • Failed: 12

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waterHeaterMixedRefactor (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1241 of 1241 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waterHeaterMixedRefactor (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (674 of 674 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waterHeaterMixedRefactor (mitchute) - Win64-Windows-10-VisualStudio-16: OK (2569 of 2581 tests passed, 5 test warnings)

Messages:\n

  • 16 tests had: MTD diffs.
  • 17 tests had: RDD diffs.
  • 9 tests had: EIO diffs.
  • 12 tests had: BND diffs.
  • 12 tests had: MDD diffs.
  • 12 tests had: Table big diffs.
  • 2 tests had: MTR small diffs.

Failures:\n

regression Test Summary

  • Passed: 657
  • Failed: 12

Build Badge Test Badge

Please sign in to comment.