Skip to content

Commit

Permalink
Updated NFP to include design documentation.
Browse files Browse the repository at this point in the history
  • Loading branch information
JasonGlazer committed Apr 16, 2020
1 parent 2dd9928 commit fd1a677
Showing 1 changed file with 28 additions and 8 deletions.
36 changes: 28 additions & 8 deletions design/FY2020/NFP-EnhancedOutdoorAirReporting.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Enhance Outdoor Air Reporting
move and rename the required airflow rate based on 62.1 computed each timestep to Voz-dyn and the associated times,
added Time Above Zero When Unoccupied
- January 27, 2020 - changed "Dynamic Zone Outdoor Airflow - Voz-dyn" to "Dynamic Target Ventilation - Voz-dyn"
- April 16, 2020 - added Design Document portion


## Justification for New Feature ##
Expand Down Expand Up @@ -670,19 +671,17 @@ will appear as shown below.
<i>Values shown at standard air density.</i>
<br><br>



## Testing/Validation/Data Sources ##

insert text
Compare current outputs including the sum of timestep results to annual results shown in the new reports.

## Input Output Reference Documentation ##

insert text
Add a paragraph for each table describing the contents of the table as part of the section on Output:Table:SummaryReports.

## Input Description ##

insert text
No changes to input.

## Outputs Description ##

Expand All @@ -695,18 +694,39 @@ New output variables would include:

Additional output varibles will be included that correspond to columns not already defined.

The OutputDetailsAndExamples documentation includes a section on eplustbl.htm containing a
description and example of the Outdoor Air Summary which would be updated.

## Engineering Reference ##

insert text
No changes to the engineering reference are expected.

## Example File and Transition Changes ##

insert text
No changes to example files or transition files are expected.

## References ##

insert text
None.

## Design Document ##

To implement the updated outdoor air summary report the following will be done:

- Update OutputReportPredefined::SetPredefinedTables() to remove unused portions of the old report, move the columns
from the old report to the new report, and add subtables and new columns to support the new version of the report.

- Update OutputReportTabular::FillRemainingPredefinedEntries() to support the new report columns and remove unused columns
of results from the old report.

- Update SystemReports::ReportMaxVentilationLoads() wqhich calculates the OA mass flow rate for each zone for both zone
equipment and air loops.

- Update DataZoneEquipment::CalcDesignSpecificationOutdoorAir() which is called by SingleDuct.cc::CalcOAMassFlow()
to support the new output columns.

- Update MixedAir::CalcOAController to support the new output columns.

Additional changes may be required to create the data needed for all the columns for the revised outdoor air summary
report subtables.

7 comments on commit fd1a677

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (2652 of 2792 tests passed, 559 test warnings)

Messages:\n

  • 589 tests had: AUD diffs.
  • 30 tests had: Table big diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 925
  • Failed: 1
  • SEGFAULT: 2

integration Test Summary

  • Passed: 591
  • Failed: 106

performance Test Summary

  • Passed: 16
  • Failed: 1

regression Test Summary

  • Passed: 682
  • Failed: 30

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (12 of 12 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1361 of 1366 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 923
  • Child aborted: 5

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: Tests Failed (547 of 697 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 547
  • Failed: 149
  • Timeout: 1

Build Badge Test Badge Coverage Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (JasonGlazer) - x86_64-MacOS-10.13-clang: OK (2695 of 2752 tests passed, 636 test warnings)

Messages:\n

  • 670 tests had: AUD diffs.
  • 34 tests had: Table big diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 927
  • Failed: 1

integration Test Summary

  • Passed: 672
  • Failed: 22

regression Test Summary

  • Passed: 658
  • Failed: 34

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (JasonGlazer) - Win64-Windows-10-VisualStudio-16: OK (2615 of 2748 tests passed, 564 test warnings)

Messages:\n

  • 592 tests had: AUD diffs.
  • 28 tests had: Table big diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 923
  • Failed: 5

integration Test Summary

  • Passed: 594
  • Failed: 100

regression Test Summary

  • Passed: 664
  • Failed: 28

Build Badge Test Badge

Please sign in to comment.