Shush warnings from third_party code?

[jmarrec]

Issue overview

Consider just ignoring every warning coming from the third_party folder.

I'm getting annoyed by lots and lots of warnings, especially on newer compilers/oses... I just tried clang 17 on an up-to-date mac 14.2.1 and the list is super duper long.

One random example:

/Users/julien/Software/Others/EnergyPlus/third_party/kiva/vendor/boost-1.77.0/boost/type_traits/has_trivial_copy.hpp:34:4: warning: builtin __has_trivial_copy is deprecated; use __is_trivially_copyable instead [-Wdeprecated-builtins]
   34 |    BOOST_HAS_TRIVIAL_COPY(T) BOOST_TT_TRIVIAL_CONSTRUCT_FIX

Possible solution is to just bump to cmake 3.25, and change this line:

EnergyPlus/CMakeLists.txt

Line 262 in 8b79a80

add_subdirectory(third_party)

to

add_subdirectory(third_party SYSTEM)

https://cmake.org/cmake/help/latest/command/add_subdirectory.html

Details

Some additional details for this issue (if relevant):

• Platform (Operating system, version)
• Version of EnergyPlus (if using an intermediate build, include SHA)
• Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Defect file added (list location of defect file here)
• Ticket added to Pivotal for defect (development team task)
• Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

[jmarrec]

Actualy SYSTEM doesn't cut it. But we can add this line here for eg:

EnergyPlus/third_party/CMakeLists.txt

Line 156 in 8b79a80

set_target_properties(libkiva PROPERTIES FOLDER ThirdParty/Kiva)

target_compile_options(libkiva PRIVATE "-w")