Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Issues - 2018b #7026

Closed
3 tasks
mjwitte opened this issue Oct 23, 2018 · 18 comments · Fixed by #7094 or #7737
Closed
3 tasks

Documentation Issues - 2018b #7026

mjwitte opened this issue Oct 23, 2018 · 18 comments · Fixed by #7094 or #7737
Assignees
Labels
Documentation Related primarily on the LaTeX-based EnergyPlus documentation

Comments

@mjwitte
Copy link
Contributor

mjwitte commented Oct 23, 2018

Issue overview

A collection of small documentation issues. See checkboxed comments below.

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version)
  • Version of EnergyPlus (if using an intermediate build, include SHA)
  • Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@mjwitte
Copy link
Contributor Author

mjwitte commented Oct 23, 2018

  • I/O Ref documentation for these output variables should appear under ZoneHVAC:AirDistributionUnit and nowhere else:
Output:Variable,*,Zone Air Terminal Sensible Heating Energy,hourly; !- HVAC Sum [J]
Output:Variable,*,Zone Air Terminal Sensible Cooling Energy,hourly; !- HVAC Sum [J]
Output:Variable,*,Zone Air Terminal Sensible Heating Rate,hourly; !- HVAC Sum [W]
Output:Variable,*,Zone Air Terminal Sensible Cooling Rate,hourly; !- HVAC Sum [W]

Currently these are repeated under a few of the specific air terminal units, but not all of them. Since these are produced with the ATU name as the key value, they should be documented there and removed elsewhere. The one exception is AirTerminal:SingleDuct:Uncontrolled which does produce it's own output variables, but that's going away soon.
Also, some of the air terminals have their own specific output variables, such as Zone Air Terminal VAV Damper Position, so don't delete those definitions.

EnergyPlus v9.0.1, unmethours 35070.

@mjwitte
Copy link
Contributor Author

mjwitte commented Oct 30, 2018

  • EMS Application Guide, description of Plant Supervisory Control, Plant Component *, On/Off Supervisory is incorrect. The current description says that zero means the component and its branch will be off (this is correct), and it says any other value means operate normally (this is not correct). Here is how it's used in the code:
    this_comp.MyLoad = min(this_comp.MaxLoad, (this_comp.MaxLoad * this_comp.EMSLoadOverrideValue));

So, the last sentence of the description should be changed:
Setting the value of this actuator to any other value directs this component and any other component on the same branch to run normally based on other controls. any value <=1.0 sets the current load for this component to the actuator value times the component maximum operating capacity which is the nominal capacity multiplied by the maximum part load ratio.

  • In the edd, this actuator is shown with units of [W], it should be [fraction], code is here.

EnergyPlus v9.0.1, unmethours 35215.

@mjwitte mjwitte added the Documentation Related primarily on the LaTeX-based EnergyPlus documentation label Nov 5, 2018
@mjwitte
Copy link
Contributor Author

mjwitte commented Nov 5, 2018

  • Engineering Reference, "Tables based on a single independent variable", in the sample idf object for Table:OneIndependentVariable, the field for "Maximum Table Output" should be 125, not 64.

EnergyPlus 9.0.1, Helpdesk 13095.

UPDATE: Fixed by #6749, but I cleaned up a stray Table:OneIndependentVariable reference.

@mjwitte
Copy link
Contributor Author

mjwitte commented Nov 16, 2018

  • Engineering Ref, v9.0.1 p. 160, the section headings for "Ground Heat Transfer Calculations using Site:GroundDomain:Slab" and Basement fall off the edge of the page.

image

@mjwitte
Copy link
Contributor Author

mjwitte commented Nov 16, 2018

  • Reading the I/O ref guide, it isn't clear what the Site:GroundDomain:Basement Aspect Ratio means. The help says:

"Numeric field used to define the height to width ratio of the slab."

Whereas for the equivalent basement object the help is clearer:

"Numeric field, which is the ratio of basement length to width, used to determine the aspect
ratio of the basement. This field along with the total basement floor area, which is taken as the
combination of all surfaces connected to the floor OtherSideConditionsModel, are used to determine
the size and shape of the basement domain. Aspect ratios and the inverse of aspect ratios should
produce identical results. i.e. AR = 2 equals AR = 0.5. This field has units of meters/meters."

Should we assume that the aspect ratio for the basement object is actually the ratio of length to width, not slab height (depth) to width?
@mitchute ?

Same is true in the Engineering Ref, for GroundDomain:Slab, the aspect ratio isn't even mentioned.

EnergyPlus v9.0.1, helpdesk ticket 13113.

@mitchute
Copy link
Collaborator

Yes, on a plan view, this is the length to width ratio.

@jmarrec
Copy link
Contributor

jmarrec commented Nov 20, 2018

image

UPDATE: References to "energyplus.net" in docs. Will verify whether each is valid.

  • ./interface-developer/src/licensing.tex (valid)
  • ./input-output-reference/src/overview/group-location-climate-weather-file-access.tex (corrected)
  • ./auxiliary-programs/src/doe2translator.tex (deleted)
  • ./auxiliary-programs/src/blasttranslator.tex (deleted)
  • ./auxiliary-programs/src/parametric-spreadsheets.tex (moved to Parametric Spreadsheet References Present in Docs but not in Repo or Install #7739 )
  • ./auxiliary-programs/src/weather-converter-program/web-resources.tex (valid)
  • ./auxiliary-programs/src/weather-converter-program/weather-data-availability.tex (valid)
  • ./getting-started/src/energyplus-overview/energyplus-documentation-library.tex (corrected)
  • ./getting-started/src/other-useful-programs-information/datafiles.tex (valid)
  • ./essentials/essentials.tex (valid)

@Myoldmopar @mjwitte Do we remove all references to DOE2Translator, BlastTranslator, and Parametric Spreadsheets?

@jmarrec
Copy link
Contributor

jmarrec commented Nov 22, 2018

  • I/O Documentation for Cooling Towers is outdated and doesn't match E+ IDD. Eg: CoolingTower:SingleSpeed doesn't mention the "Design Approach Temperature", "Design Range Temperature", etc (Also typo: "Regine" instead of "Regime). Same for TwoSpeed at least

@MatthewSteen
Copy link
Member

MatthewSteen commented Dec 11, 2018

I/O for Boiler:HotWater missing the field Design Water Outlet Temperature here before the Design Water Flow Rate field.

@Nigusse
Copy link
Contributor

Nigusse commented Dec 11, 2018

@MatthewSteen the field "Design Water Outlet Temperature" has been removed.

@MatthewSteen
Copy link
Member

MatthewSteen commented Dec 12, 2018

@Nigusse my mistake. I noticed it in an OpenStudio model (2.7.0 with EP 9.0), but was looking at the 8.9 IDF Editor.

@mjwitte
Copy link
Contributor Author

mjwitte commented Dec 19, 2018

  • Engineering Reference, "Photovoltaic Thermal Flat-Plate Solar Collectors", this sentence:

EnergyPlus currently has one simple model based on user-defined efficiencies but a more detailed model based on first-principles and a detailed, layer-by-layer description is under development.

Should be changed to:

EnergyPlus currently has one simple model based on user-defined efficiencies. but a more detailed model based on first-principles and a detailed, layer-by-layer description is under development.
.

@JasonGlazer
Copy link
Contributor

JasonGlazer commented Jan 29, 2019

The following are moved to #7760

  • [ ] The organization of groups in the IOref does not always match the arrangement in the IDD!
  • [ ] The IDD group Natural Ventilation and Duct Leakage is shown in the IOref as AirflowNetwork
  • [ ] The IDD has Water Heaters and Thermal Storage group that includes thermal storage objects but they are described in the IOref under Plant Equipment
  • [ ] The IDD has Zone HVAC Air Loop Terminal Units group but in the IOref it is called Air Distribution Equipment
  • [ ] The IDD has one group called Humdifiers and Dehumidifiers but the IOref has two separate groups called Humidifiers and another called Desiccant Dehumidifiers

@mjwitte
Copy link
Contributor Author

mjwitte commented Aug 8, 2019

Reopening this - it was mistakenly closed via github magic. I think most of these have not been addressed.

@mjwitte mjwitte reopened this Aug 8, 2019
@mitchute mitchute self-assigned this Feb 3, 2020
@mitchute
Copy link
Collaborator

mitchute commented Feb 4, 2020

@mjwitte @Myoldmopar The Yahoo! user's group is dead, right? We should get it removed from https://energyplus.net/support

@mjwitte
Copy link
Contributor Author

mjwitte commented Feb 6, 2020

@mitchute Not yet, the yahoo group is still there at the moment.

@mitchute mitchute linked a pull request Feb 7, 2020 that will close this issue
20 tasks
@mitchute
Copy link
Collaborator

@mjwitte I'm going to open a separate issue to track the Yahoo! user group.

@JasonGlazer I'm moving these remaining open issues to a new doc-fix issue so this can wrap up soon. I think there's a chance we may need to reorder objects in the IDD to resolve these, but since we're so close to the IDD freeze I'd rather not take a chance in this not getting in.

@JasonGlazer
Copy link
Contributor

@mitchute ok, I understand that the issues that I raised were complicated. It is probably worth a thorough review of the IDD and IOref.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related primarily on the LaTeX-based EnergyPlus documentation
Projects
None yet
6 participants