Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more multistage heating coils in AFN #10393

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

lgu1234
Copy link
Contributor

@lgu1234 lgu1234 commented Feb 5, 2024

Pull request overview

When multispeed heat pump is used in the AFN model, the allowed heating coil is DX heating coil and no multistage heating coils are allowed. The fix allows two more types heating coils in the AirflowNetwork:Distribution:Component:Coil:

  \key Coil:Heating:Electric:MultiStage
  \key Coil:Heating:Gas:MultiStage

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • [X ] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • [X ] Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • [X ] Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • [ X] Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • [X ] If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@lgu1234 lgu1234 added Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) AirflowNetwork Related primarily on airflow-network portions of the codebase labels Feb 5, 2024
ErrorsFound = true;
} else {
SetHeatingCoilAirLoopNumber(m_state, DisSysCompCoilData(i).name, DisSysCompCoilData(i).AirLoopNum, ErrorsFound);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow two more multistage heating coils

Copy link
Member

@Myoldmopar Myoldmopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems extremely straightforward. It does touch AFN, so I will ping @jasondegraw for comments, but it doesn't seem to really be doing anything controversial. If anyone has thoughts, speak up!

@Myoldmopar Myoldmopar added this to the EnergyPlus 24.1 IOFreeze milestone Feb 19, 2024
@Myoldmopar
Copy link
Member

I pulled develop in and resolved the unit test conflict. It was just that two different unit tests were added to the bottom. Everything builds and passes fine. If no one has any additional comments, and this is fine on CI, I'll merge this today.

@Myoldmopar
Copy link
Member

CI was all happy here, I'm merging this one in. Thanks @lgu1234

@Myoldmopar Myoldmopar merged commit ebe2db8 into develop Feb 20, 2024
15 checks passed
@Myoldmopar Myoldmopar deleted the 10389-Allow-more-multistage-heating-coils branch February 20, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AirflowNetwork Related primarily on airflow-network portions of the codebase Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow more multistage heating coils for AFN model
7 participants