-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more multistage heating coils in AFN #10393
Allow more multistage heating coils in AFN #10393
Conversation
ErrorsFound = true; | ||
} else { | ||
SetHeatingCoilAirLoopNumber(m_state, DisSysCompCoilData(i).name, DisSysCompCoilData(i).AirLoopNum, ErrorsFound); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow two more multistage heating coils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems extremely straightforward. It does touch AFN, so I will ping @jasondegraw for comments, but it doesn't seem to really be doing anything controversial. If anyone has thoughts, speak up!
I pulled develop in and resolved the unit test conflict. It was just that two different unit tests were added to the bottom. Everything builds and passes fine. If no one has any additional comments, and this is fine on CI, I'll merge this today. |
CI was all happy here, I'm merging this one in. Thanks @lgu1234 |
Pull request overview
When multispeed heat pump is used in the AFN model, the allowed heating coil is DX heating coil and no multistage heating coils are allowed. The fix allows two more types heating coils in the AirflowNetwork:Distribution:Component:Coil:
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.