Fix (Probable) Fan Coil Sizing Issue #10461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rraustad
reviewed
Apr 9, 2024
| EXPECT_NEAR(state->dataLoopNodes->Node(thisFanCoil.ATMixerSecNode).MassFlowRate, 0.369714, 0.000001); | ||
| EXPECT_NEAR(state->dataLoopNodes->Node(thisFanCoil.ATMixerOutNode).MassFlowRate, 0.569714, 0.000001); | ||
| EXPECT_NEAR(state->dataLoopNodes->Node(thisFanCoil.ATMixerSecNode).MassFlowRate, 0.350865, 0.000001); // Was 0.369714 | ||
| EXPECT_NEAR(state->dataLoopNodes->Node(thisFanCoil.ATMixerOutNode).MassFlowRate, 0.550865, 0.000001); // Was 0.569714 |
There was a problem hiding this comment.
Yeah, this is the same thing I see. I still can't figure out why this unit test fails now and not last year when that 1 line (line 515 in FanCoilUnits) was commented out (#9932 on Apr 3, 2023). It makes sense that the cooling coil is now larger (by 496.3 W of fan power) and the PLR is lower which changes the air flow numbers. The example file FanCoilAutoSize skips sizing the first time through but calls the fan (also skips sizing), which sets the fanIndex so there is no change in results when sizing finally does occur. That explains the example files but not this unit test.
|
@Myoldmopar I tried to merge this and came up with a failed attempt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very quick one. In the process of testing a set of refactoring changes I ran into a unit test failure where the fan index was not set on an FCU until after sizing, causing the heat generated by the fan to not be accounted. It turns out that this diff was caused by a line that was commented out, likely in error. A comment above the line confirms this suspicion. @rraustad confirms it also. The only change in this PR is to uncomment this line.