Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10531 - Use non-deprecated Github Actions #10532

Merged
merged 5 commits into from
Jun 3, 2024
Merged

#10531 - Use non-deprecated Github Actions #10532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a71f66
for #10531 - add a python script to update GHA actions
jmarrec May 28, 2024
28b37de
Add --safe argument and run with it
jmarrec May 28, 2024
76bac72
Run without --safe
jmarrec May 28, 2024
0325b33
Add dependabot for github actions (don't know how annoying this will …
jmarrec May 28, 2024
ea23028
Add license text to script... [decent_ci_skip]
jmarrec May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
version: 2
updates:

- package-ecosystem: "github-actions"
directory: "/"
schedule:
# Check for updates to GitHub Actions every week
interval: "weekly"
Comment on lines +1 to +8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need tweaking to be less annoying (filtering on semver:major only maybe), we'll see. I'll do it as needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filtering to semver:major does seem pretty reasonable. But also...maybe weekly isn't too bad regardless. Is there a dependabot or whatever that can open PRs automatically to take the weekly pain down a bit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will open PRs yes. https://docs.github.com/en/code-security/dependabot/working-with-dependabot/managing-pull-requests-for-dependency-updates#about-dependabot-pull-requests

2 changes: 1 addition & 1 deletion .github/workflows/add_opened_pr_to_project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ubuntu-latest
steps:
# check out the repo to get the script downloaded
- uses: actions/checkout@v3
- uses: actions/checkout@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, of course. Any preference to using the full SHA instead of a tag? Is that safer/preferred?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github official actions are safe to pin to a major tag.

# gets the current PR and stores it in a variable
- uses: jwalton/gh-find-current-pr@v1
id: findPr
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ jobs:

steps:
- name: Checkout EnergyPlus
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ github.event.inputs.ref }}

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v3
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}

Expand All @@ -41,7 +41,7 @@ jobs:
pip install wheel
python setup.py bdist_wheel

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: energyplus-wheel-${{ matrix.os }}
path: ./dist
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/clang-format-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ jobs:
- 'src/EnergyPlus'
- 'tst/EnergyPlus/unit'
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Run clang-format style check for C/C++ programs.
uses: jidicula/clang-format-action@v4.10.1
uses: jidicula/clang-format-action@v4.13.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of two deps that aren't github official that I bumped

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Same question about using the full SHA for resilience/safety? Probably not important, just asking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a "community" maintained action, so pinning to a minor/patch isn't a bad idea.

with:
clang-format-version: '10'
check-path: ${{ matrix.path }}
6 changes: 3 additions & 3 deletions .github/workflows/cppcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:

steps:
- name: Checkout EnergyPlus
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install cppcheck
shell: bash
Expand All @@ -30,7 +30,7 @@ jobs:

- name: Cache cppcheck-build-directory
id: cppcheckcache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: .cppcheck-build-dir/
key: cppcheckcache
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:

- name: Upload cppcheck results as artifact
if: ${{ always() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: EnergyPlus-${{ github.sha }}-cppcheck_results.txt
path: cppcheck.txt
4 changes: 2 additions & 2 deletions .github/workflows/custom_check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
os: [ubuntu-latest]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up Python 3.10
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: '3.10'

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/documentation-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:

steps:
- name: Checkout EnergyPlus
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up Python 3.10
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: '3.10'

Expand Down Expand Up @@ -103,14 +103,14 @@ jobs:

- name: Upload entire pdf folder
if: ${{ always() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: InputOutputReference
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/

- name: Upload log folder upon failure
if: ${{ failure() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Xelatex_Logs_after_all
path: C:\Users\runneradmin\AppData\Local\MiKTeX\miktex\log\
30 changes: 15 additions & 15 deletions .github/workflows/documentation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:

steps:
- name: Checkout EnergyPlus
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up Python 3.10
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: '3.10'

Expand All @@ -33,79 +33,79 @@ jobs:
run: cmake --build . -j 4

- name: Upload Acknowledgments
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Acknowledgments
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/Acknowledgments.pdf

- name: Upload AuxiliaryPrograms
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: AuxiliaryPrograms
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/AuxiliaryPrograms.pdf

- name: Upload EMSApplicationGuide
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: EMSApplicationGuide
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/EMSApplicationGuide.pdf

- name: Upload EnergyPlusEssentials
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: EnergyPlusEssentials
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/EnergyPlusEssentials.pdf

- name: Upload EngineeringReference
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: EngineeringReference
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/EngineeringReference.pdf

- name: Upload ExternalInterfacesApplicationGuide
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ExternalInterfacesApplicationGuide
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/ExternalInterfacesApplicationGuide.pdf

- name: Upload GettingStarted
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: GettingStarted
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/GettingStarted.pdf

- name: Upload InputOutputReference
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: InputOutputReference
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/InputOutputReference.pdf

- name: Upload InterfaceDeveloper
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: InterfaceDeveloper
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/InterfaceDeveloper.pdf

- name: Upload ModuleDeveloper
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ModuleDeveloper
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/ModuleDeveloper.pdf

- name: Upload OutputDetailsAndExamples
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: OutputDetailsAndExamples
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/OutputDetailsAndExamples.pdf

- name: Upload PlantApplicationGuide
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: PlantApplicationGuide
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/PlantApplicationGuide.pdf

- name: Upload UsingEnergyPlusForCompliance
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: UsingEnergyPlusForCompliance
path: ${{runner.workspace}}/EnergyPlus/doc/build/pdf/UsingEnergyPlusForCompliance.pdf
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/epjson.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
os: [ubuntu-latest, windows-latest, macos-latest]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up Python 3.10
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: '3.10'

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/linux_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
# os: [ubuntu-20.04]
#
# steps:
# - uses: actions/checkout@v3
# - uses: actions/checkout@v4
#
# - name: Set up Python 3.7
# uses: actions/setup-python@v4
# uses: actions/setup-python@v5
# with:
# python-version: 3.7
#
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
os: [ubuntu-20.04]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Install System Dependencies
shell: bash
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/linux_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ jobs:
contents: write

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up Python ${{ env.Python_REQUIRED_VERSION }}
id: setup-python
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: ${{ env.Python_REQUIRED_VERSION }}

Expand Down Expand Up @@ -129,12 +129,12 @@ jobs:
test_key: ubuntu2204

steps:
- uses: actions/checkout@v3 # Still need E+ checked out to get testing scripts
- uses: actions/checkout@v4 # Still need E+ checked out to get testing scripts
with:
path: checkout

- name: Set up Python ${{ env.Python_REQUIRED_VERSION }}
uses: actions/setup-python@v4
uses: actions/setup-python@v5
id: setup-python
with:
python-version: ${{ env.Python_REQUIRED_VERSION }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/mac_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ jobs:
contents: write

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up Python ${{ matrix.python }}
id: setup-python
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python }}

Expand Down Expand Up @@ -164,12 +164,12 @@ jobs:
# python: 3.12.0 # Make sure to add the package testing below for ARM once we add this build to GHA

steps:
- uses: actions/checkout@v3 # Still need E+ checked out to get testing scripts
- uses: actions/checkout@v4 # Still need E+ checked out to get testing scripts
with:
path: checkout

- name: Set up Python ${{ env.Python_REQUIRED_VERSION }}
uses: actions/setup-python@v4
uses: actions/setup-python@v5
id: setup-python
with:
python-version: ${{ env.Python_REQUIRED_VERSION }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr_labels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Verify PR label action
uses: mheap/github-action-required-labels@v3
uses: mheap/github-action-required-labels@v5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other of two deps that aren't github official that I bumped

with:
mode: minimum
count: 1
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/windows_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ jobs:
contents: write

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up Python ${{ env.Python_REQUIRED_VERSION }}
uses: actions/setup-python@v4
uses: actions/setup-python@v5
id: setup-python
with:
python-version: ${{ env.Python_REQUIRED_VERSION }}
Expand Down Expand Up @@ -177,12 +177,12 @@ jobs:
runs-on: windows-2019

steps:
- uses: actions/checkout@v3 # Still need E+ checked out to get testing scripts
- uses: actions/checkout@v4 # Still need E+ checked out to get testing scripts
with:
path: checkout

- name: Set up Python ${{ env.Python_REQUIRED_VERSION }}
uses: actions/setup-python@v4
uses: actions/setup-python@v5
id: setup-python
with:
python-version: ${{ env.Python_REQUIRED_VERSION }}
Expand Down
Loading
Loading