Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves #10682

jmarrec · 2024-08-21T17:17:08Z

Pull request overview

Fixes HeatPump:AirToWater:FuelFired:Heating curves not using two independent temperature variables #10665

Using PlantLoopHeatPump_Fuel-Fired.idf , before versus after, plotting the CAPCURVEFUNCTEMP2

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

``` [ RUN ] EnergyPlusFixture.GAHP_AirSource_CurveEval /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5650: Failure Expected equality of these values: oaTemp Which is: 3 oaTempforCurve Which is: 43.0859 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5658: Failure Expected equality of these values: oaTemp Which is: 3 oaTempforCurve Which is: 43.0859 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5664: Failure Expected equality of these values: oaTemp Which is: 3 oaTempforCurve Which is: 3.33333 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5693: Failure Expected equality of these values: oaTemp Which is: 3 oaTempforCurve Which is: 43.0859 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5701: Failure Expected equality of these values: oaTemp Which is: 3 oaTempforCurve Which is: 43.0859 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5736: Failure Expected equality of these values: oaWetbulb Which is: -4.36026 oaTempforCurve Which is: 15.7288 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5744: Failure Expected equality of these values: oaWetbulb Which is: -4.36026 oaTempforCurve Which is: 15.7288 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5750: Failure Expected equality of these values: oaWetbulb Which is: -4.36026 oaTempforCurve Which is: 3.33333 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5778: Failure Expected equality of these values: oaWetbulb Which is: -4.36026 oaTempforCurve Which is: 17.0828 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5786: Failure Expected equality of these values: oaWetbulb Which is: -4.36026 oaTempforCurve Which is: 17.0828 [ FAILED ] EnergyPlusFixture.GAHP_AirSource_CurveEval (900 ms) ```

…ide air temperatures to evaluate curves

jmarrec · 2024-08-21T17:17:21Z

Now, I change the evaluation variables

jmarrec · 2024-08-21T17:19:09Z

tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc

+        "HeatPump:AirToWater:FuelFired:Heating,",
+        "  FuelFired GAHP Heating,                 !- Name",
+        "  Node 3,                                 !- Water Inlet Node Name",
+        "  Node 7,                                 !- Water Outlet Node Name",
+        "  FuelFired GAHP Heating OA Node,         !- Air Source Node Name",
+        "  FuelFired GAHP Cooling,                 !- Companion Cooling Heat Pump Name",
+        "  NaturalGas,                             !- Fuel Type",
+        "  GAHP,                                   !- End-Use Subcategory",
+        "  3000,                                   !- Nominal Heating Capacity {W}",
+        "  1.5,                                    !- Nominal COP {W/W}",
+        "  0.005,                                  !- Design Flow Rate {m3/s}",
+        "  60,                                     !- Design Supply Temperature {C}",
+        "  11.1,                                   !- Design Temperature Lift {deltaC}",
+        "  1,                                      !- Sizing Factor",
+        "  NotModulated,                           !- Flow Mode",
+        "  DryBulb,                                !- Outdoor Air Temperature Curve Input Variable",
+        "  EnteringCondenser,                      !- Water Temperature Curve Input Variable",
+        "  CapCurveFuncTemp,                       !- Normalized Capacity Function of Temperature Curve Name",
+        "  EIRCurveFuncTemp,                       !- Fuel Energy Input Ratio Function of Temperature Curve Name",
+        "  EIRCurveFuncPLR,                        !- Fuel Energy Input Ratio Function of PLR Curve Name",
+        "  0.1,                                    !- Minimum Part Load Ratio",
+        "  1,                                      !- Maximum Part Load Ratio",
+        "  OnDemand,                               !- Defrost Control Type",
+        "  0,                                      !- Defrost Operation Time Fraction",
+        "  EIRDefrostFoTCurve,                     !- Fuel Energy Input Ratio Defrost Adjustment Curve Name",
+        "  0,                                      !- Resistive Defrost Heater Capacity {W}",
+        "  5,                                      !- Maximum Outdoor Dry-bulb Temperature for Defrost Operation {C}",
+        "  CRFCurve,                               !- Cycling Ratio Factor Curve Name",
+        "  500,                                    !- Nominal Auxiliary Electric Power {W}",
+        "  auxElecEIRCurveFuncTempCurve,           !- Auxiliary Electric Energy Input Ratio Function of Temperature Curve Name",
+        "  auxElecEIRFoPLRCurve,                   !- Auxiliary Electric Energy Input Ratio Function of PLR Curve Name",
+        "  20;                                     !- Standby Electric Power {W}",
+
+        "OutdoorAir:Node,",
+        "  FuelFired GAHP Heating OA Node;         !- Name",
+
+        "HeatPump:AirToWater:FuelFired:Cooling,",
+        "  FuelFired GAHP Cooling,                 !- Name",
+        "  FuelFired GAHP Cooling Water Inlet Node, !- Water Inlet Node Name",
+        "  FuelFired GAHP Cooling Water Outlet Node, !- Water Outlet Node Name",
+        "  FuelFired GAHP Cooling OA Node,         !- Air Source Node Name",
+        "  FuelFired GAHP Heating,                 !- Companion Heating Heat Pump Name",
+        "  NaturalGas,                             !- Fuel Type",
+        "  GAHP,                                   !- End-Use Subcategory",
+        "  4000,                                   !- Nominal Cooling Capacity {W}",
+        "  2,                                      !- Nominal COP {W/W}",
+        "  0.006,                                  !- Design Flow Rate {m3/s}",
+        "  7,                                      !- Design Supply Temperature {C}",
+        "  11.1,                                   !- Design Temperature Lift {deltaC}",
+        "  1,                                      !- Sizing Factor",
+        "  NotModulated,                           !- Flow Mode",
+        "  DryBulb,                                !- Outdoor Air Temperature Curve Input Variable",
+        "  EnteringEvaporator,                     !- Water Temperature Curve Input Variable",
+        "  CapCurveFuncTemp,                       !- Normalized Capacity Function of Temperature Curve Name",
+        "  EIRCurveFuncTemp,                       !- Fuel Energy Input Ratio Function of Temperature Curve Name",
+        "  EIRCurveFuncPLR,                        !- Fuel Energy Input Ratio Function of PLR Curve Name",
+        "  0.1,                                    !- Minimum Part Load Ratio",
+        "  1,                                      !- Maximum Part Load Ratio",
+        "  CRFCurve,                               !- Cycling Ratio Factor Curve Name",
+        "  500,                                    !- Nominal Auxiliary Electric Power {W}",
+        "  auxElecEIRCurveFuncTempCurve,           !- Auxiliary Electric Energy Input Ratio Function of Temperature Curve Name",
+        "  auxElecEIRFoPLRCurve,                   !- Auxiliary Electric Energy Input Ratio Function of PLR Curve Name",
+        "  20;                                     !- Standby Electric Power {W}",


Prepare a unit test with a HeatPump:AirToWater:FuelFired:Heating and HeatPump:AirToWater:FuelFired:Cooling object, having all curves defined.

jmarrec · 2024-08-21T17:19:34Z

tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc

+    // This is not the case, even though the E+ I/O Documentation says it should
+    constexpr bool isLoadSideHeatTransferNegativeForCooling = false;


Side note...

jmarrec · 2024-08-21T17:21:34Z

tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc

+    thisHeatingPLHP->onInitLoopEquip(*state, myHeatingLoadLocation);
+    {
+        EXPECT_ENUM_EQ(EIRFuelFiredHeatPump::OATempCurveVar::DryBulb, thisHeatingPLHP->oaTempCurveInputVar);
+        EXPECT_ENUM_EQ(EIRFuelFiredHeatPump::WaterTempCurveVar::EnteringCondenser, thisHeatingPLHP->waterTempCurveInputVar);
+
+        bool firstHVAC = true;
+        Real64 curLoad = 800;
+        bool runFlag = true;
+        Real64 const calculatedLoadInletTemp = specifiedLoadSetpoint - curLoad / (expectedLoadMassFlowRate * expectedCp);
+
+        state->dataLoopNodes->Node(thisHeatingPLHP->loadSideNodes.inlet).Temp = calculatedLoadInletTemp;
+        state->dataLoopNodes->Node(thisHeatingPLHP->loadSideNodes.outlet).TempSetPoint = specifiedLoadSetpoint;
+        state->dataLoopNodes->Node(thisHeatingPLHP->sourceSideNodes.inlet).Temp = oaTemp;
+
+        thisHeatingPLHP->simulate(*state, myHeatingLoadLocation, firstHVAC, curLoad, runFlag);
+        // expect it to meet setpoint and have some pre-evaluated conditions
+        // EXPECT_NEAR(specifiedLoadSetpoint, thisHeatingPLHP->loadSideOutletTemp, 0.001);
+        EXPECT_NEAR(curLoad, thisHeatingPLHP->loadSideHeatTransfer, 0.001);
+        {
+            ASSERT_GT(thisHeatingPLHP->capFuncTempCurveIndex, 0);
+            auto const *thisCurve = state->dataCurveManager->PerfCurve(thisHeatingPLHP->capFuncTempCurveIndex);
+            Real64 const waterTempforCurve = thisCurve->inputs[0];
+            Real64 const oaTempforCurve = thisCurve->inputs[1];
+            EXPECT_EQ(calculatedLoadInletTemp, waterTempforCurve);
+            EXPECT_EQ(oaTemp, oaTempforCurve);
+        }
+        {
+            ASSERT_GT(thisHeatingPLHP->powerRatioFuncTempCurveIndex, 0);
+            auto const *thisCurve = state->dataCurveManager->PerfCurve(thisHeatingPLHP->powerRatioFuncTempCurveIndex);
+            Real64 const waterTempforCurve = thisCurve->inputs[0];
+            Real64 const oaTempforCurve = thisCurve->inputs[1];
+            EXPECT_EQ(calculatedLoadInletTemp, waterTempforCurve);
+            EXPECT_EQ(oaTemp, oaTempforCurve);
+        }
+        {
+            ASSERT_GT(thisHeatingPLHP->defrostEIRCurveIndex, 0);
+            auto const *thisCurve = state->dataCurveManager->PerfCurve(thisHeatingPLHP->defrostEIRCurveIndex);
+            Real64 const oaTempforCurve = thisCurve->inputs[0];
+            EXPECT_EQ(oaTemp, oaTempforCurve);
+        }
+    }


So I'm going to do 4 calls to simulate:

For object in "Heating", "Cooling"

Simulate with Drybulb and Entering Condenser/Evaporator temperature

Simulate with Welbulb and Leaving Condenser/Evaporator temperature

For each of these, I check that the curves were evaluated with the proper conditions

jmarrec · 2024-08-21T17:21:44Z

src/EnergyPlus/PlantLoopHeatPumpEIR.cc

@@ -2549,6 +2549,7 @@ void EIRFuelFiredHeatPump::doPhysics(EnergyPlusData &state, Real64 currentLoad)
    // will not shut down the branch
    auto &thisInletNode = state.dataLoopNodes->Node(this->loadSideNodes.inlet);
    auto &thisOutletNode = state.dataLoopNodes->Node(this->loadSideNodes.outlet);
+    auto &thisSourceSideInletNode = state.dataLoopNodes->Node(this->sourceSideNodes.inlet); // OA Intake node


jmarrec · 2024-08-21T17:21:59Z

src/EnergyPlus/PlantLoopHeatPumpEIR.cc

@@ -2720,10 +2721,10 @@ void EIRFuelFiredHeatPump::doPhysics(EnergyPlusData &state, Real64 currentLoad)
    // Determine which air variable to use for GAHP:
    // Source (air) side variable to use
    // auto &thisloadsideinletnode = state.dataLoopNodes->Node(this->loadSideNodes.inlet);
-    Real64 oaTempforCurve = thisInletNode.Temp; // state.dataLoopNodes->Node(this->loadSideNodes.inlet).Temp;
+    Real64 oaTempforCurve = this->sourceSideInletTemp; // state.dataLoopNodes->Node(this->loadSideNodes.inlet).Temp;


Fix one, for OA Drybulb

jmarrec · 2024-08-21T17:22:11Z

src/EnergyPlus/PlantLoopHeatPumpEIR.cc

+        oaTempforCurve = Psychrometrics::PsyTwbFnTdbWPb(
+            state, thisSourceSideInletNode.Temp, thisSourceSideInletNode.HumRat, thisSourceSideInletNode.Press, "PLFFHPEIR::doPhysics()");


Fix 2, If Wetbulb, evaluate it

mjwitte

Code changes look correct. Tested with modified example file, and can see the correct input temps for the curves.

Unit test GAHP_HeatingSimulate_AirSource_with_Defrost is failing.

mjwitte · 2024-09-09T20:18:01Z

tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc

+        "Curve:Biquadratic,",
+        "  CapCurveFuncTemp,                       !- Name",
+        "  1,                                      !- Coefficient1 Constant",
+        "  0,                                      !- Coefficient2 x",


It would be nice if these curves actually computed a value instead of a constant 1.0. The constant fT curves in the example file explain why there are no diffs. That would be nice to change, but not sure where to get a reasonable set of curves.

mjwitte · 2024-09-09T20:50:13Z

Also, this applies to both the cooling and heating side of this heat pump.

Myoldmopar · 2024-09-10T18:05:57Z

Unit test GAHP_HeatingSimulate_AirSource_with_Defrost is failing.

Thanks for looking this over and noticing the failing unit test. I'm assuming the unit test was simply using the wrong numbers and things are now more correct. I can make an attempt at fixing up the unit test to get this in unless @jmarrec wants to get it running.

…_CurveEval

mjwitte · 2024-09-11T20:47:46Z

@Myoldmopar @jmarrec The failing unit test needs updated results to align with this fix. Here's one of the parts that fails:

EnergyPlus/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc

Lines 4537 to 4542 in 2830ccc

    
           state->dataLoopNodes->Node(thisHeatingPLHP->loadSideNodes.outlet).TempSetPoint = specifiedLoadSetpoint; 
        
           state->dataLoopNodes->Node(thisHeatingPLHP->loadSideNodes.inlet).Temp = calculatedLoadInletTemp; 
        
           state->dataLoopNodes->Node(thisHeatingPLHP->sourceSideNodes.inlet).Temp = 30; 
        
           thisHeatingPLHP->simulate(*state, myLoadLocation, firstHVAC, curLoad, runFlag); 
        
           EXPECT_NEAR(19200.0, thisHeatingPLHP->fuelRate, 0.001); 
        
           EXPECT_NEAR(17280000.0, thisHeatingPLHP->fuelEnergy, 0.001);

If I set Node(thisHeatingPLHP->sourceSideNodes.inlet).Temp = calculatedLoadInletTemp; (to mimic the bug) then the test passes. I will push up a fix soon with updated numbers.

mjwitte · 2024-09-12T02:45:47Z

@Myoldmopar CI is green and happy here. In the merge queue.

jmarrec · 2024-09-12T07:21:20Z

Sorry I wasn't responsive, been swamped. Thanks a lot @mjwitte for updating the test!

Myoldmopar · 2024-09-12T16:17:23Z

Yes indeed, thanks for fixing the test @mjwitte ! I'll pull develop and double check things.

Myoldmopar · 2024-09-12T16:21:58Z

Yep still good here, thanks @jmarrec and @mjwitte, merging.

jmarrec added 2 commits August 21, 2024 19:15

Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outs…

041f5db

…ide air temperatures to evaluate curves

jmarrec added Defect Includes code to repair a defect in EnergyPlus NotIDDChange Code does not impact IDD (can be merged after IO freeze) labels Aug 21, 2024

jmarrec requested a review from Myoldmopar August 21, 2024 17:17

jmarrec self-assigned this Aug 21, 2024

jmarrec mentioned this pull request Aug 21, 2024

Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves #10681

Closed

20 tasks

jmarrec commented Aug 21, 2024

View reviewed changes

jmarrec mentioned this pull request Aug 27, 2024

Coil:Cooling:DX:VariableSpeed should be converted to new sizing routines and respect DesignSpecification:ZoneHVAC:Sizing #10699

Open

3 tasks

mjwitte reviewed Sep 9, 2024

View reviewed changes

Myoldmopar assigned mjwitte Sep 11, 2024

Myoldmopar added this to the EnergyPlus 24.2 milestone Sep 11, 2024

Merge remote-tracking branch 'remotes/origin/develop' into 10665_GAHP…

5a14785

…_CurveEval

Fix GAHP unit test

afef936

Myoldmopar merged commit b723d7b into develop Sep 12, 2024
10 checks passed

Myoldmopar deleted the 10665_GAHP_CurveEval branch September 12, 2024 16:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves #10682

Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves #10682

jmarrec commented Aug 21, 2024 •

edited

Loading

jmarrec commented Aug 21, 2024

jmarrec Aug 21, 2024

jmarrec Aug 21, 2024

jmarrec Aug 21, 2024

jmarrec Aug 21, 2024

jmarrec Aug 21, 2024

jmarrec Aug 21, 2024

mjwitte left a comment

mjwitte Sep 9, 2024

mjwitte commented Sep 9, 2024

Myoldmopar commented Sep 10, 2024

mjwitte commented Sep 11, 2024

mjwitte commented Sep 12, 2024

jmarrec commented Sep 12, 2024

Myoldmopar commented Sep 12, 2024

Myoldmopar commented Sep 12, 2024

		// This is not the case, even though the E+ I/O Documentation says it should
		constexpr bool isLoadSideHeatTransferNegativeForCooling = false;

		oaTempforCurve = Psychrometrics::PsyTwbFnTdbWPb(
		state, thisSourceSideInletNode.Temp, thisSourceSideInletNode.HumRat, thisSourceSideInletNode.Press, "PLFFHPEIR::doPhysics()");

Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves #10682

Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves #10682

Conversation

jmarrec commented Aug 21, 2024 • edited Loading

Pull request overview

Pull Request Author

Reviewer

jmarrec commented Aug 21, 2024

jmarrec Aug 21, 2024

Choose a reason for hiding this comment

jmarrec Aug 21, 2024

Choose a reason for hiding this comment

jmarrec Aug 21, 2024

Choose a reason for hiding this comment

jmarrec Aug 21, 2024

Choose a reason for hiding this comment

jmarrec Aug 21, 2024

Choose a reason for hiding this comment

jmarrec Aug 21, 2024

Choose a reason for hiding this comment

mjwitte left a comment

Choose a reason for hiding this comment

mjwitte Sep 9, 2024

Choose a reason for hiding this comment

mjwitte commented Sep 9, 2024

Myoldmopar commented Sep 10, 2024

mjwitte commented Sep 11, 2024

mjwitte commented Sep 12, 2024

jmarrec commented Sep 12, 2024

Myoldmopar commented Sep 12, 2024

Myoldmopar commented Sep 12, 2024

jmarrec commented Aug 21, 2024 •

edited

Loading