Fix Bug Uncovered in PR #10646 #10696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirroth
added
Defect
amirroth
commented
Aug 25, 2024
| @@ -6441,7 +6441,7 @@ void CalcInteriorSolarDistribution(EnergyPlusData &state) | |||
| if (state.dataSurface->SurfWinWindowModelType(SurfNum) != WindowModel::EQL && ANY_BLIND(ShadeFlag)) { | |||
| int SlatsAngIndexLower = state.dataSurface->SurfWinSlatsAngIndex(SurfNum); | |||
| int ProfAngIndexLower = state.dataSurface->SurfWinProfAngIndex(SurfNum); | |||
| int SlatsAngIndexUpper = std::min(Material::MaxProfAngs, SlatsAngIndexLower + 1); | |||
| int SlatsAngIndexUpper = std::min(Material::MaxSlatAngs, SlatsAngIndexLower + 1); | |||
There was a problem hiding this comment.
Here are the changes. No explanation necessary.
There was a problem hiding this comment.
Not sure about this. Just kidding. Good stuff, thanks @amirroth
Myoldmopar
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #10646 uncovered a bug in which the maximum number of profile angles was used to cap slat angle calculations. This bug was uncovered when the maximum number of slat angles was increased to greatly exceed the number of profile angles. I'm not sure why I didn't notice this during PR #10646.
There are expected diffs in the three testfiles that use blinds with variable slat angles. I believe that these changes will partially the diffs that #10646 showed, which is also good.