Set the correct identifier for variable speed cooling tower in GetTowerInput

[lymereJ]

Pull request overview

• Fixes Runaway temperature error from chiller condenser flow control changes #10858

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport: in_V2410.zip

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[lymereJ]

The variable speed tower index used to be based on the variable speed tower indices, and not on all the cooling tower indices. So for instances where different types of tower are modeled together the wrong inputs were retrieved. For this file, the two speed tower inputs were being retrieved for the variable speed tower.

This issue did not come up before 24.2 because of #7464, the tower calculation were failing silently.

[mjwitte]

So, if I'm following this correctly, we no longer need the field VSTower and eliminating that would simplify the code in places like this in CoolingTower:onInitLoopEquip:

EnergyPlus/src/EnergyPlus/CondenserLoopTowers.cc

Lines 3278 to 3282 in aa39f9f

	Real64 const FlowRateRatioStep = (state.dataCondenserLoopTowers->towers(this->VSTower).MaxWaterFlowRatio -
	state.dataCondenserLoopTowers->towers(this->VSTower).MinWaterFlowRatio) /
	10.0;
	bool ModelCalibrated = true;
	Real64 ModelWaterFlowRatioMax = state.dataCondenserLoopTowers->towers(this->VSTower).MaxWaterFlowRatio *

where (state.dataCondenserLoopTowers->towers(this->VSTower).MaxWaterFlowRatio
would become this->MaxWaterFlowRatio

[lymereJ]

I think that this is correct. I can make that change throughout.

[lymereJ]

@mjwitte, done!

[mjwitte]

Fix works as expected. Compared annual simulations with 24.1 and this branch and annual results are very similar. And thanks @lymereJ for the additional code cleanup.

[Myoldmopar]

Fine change and set of cleanups. I'll do a quick check with latest develop, but this is probably still ready to go.

[Myoldmopar]

It all passes fine, although now I'm noticing the LgOffVAVusingBasement test is taking notably longer on my machine. Once my brain reboots after the holidays I'll go back and see why. But this doesn't need to wait, good to go. Thanks @lymereJ and @mjwitte