Coil leaving air humidity ratio in Coil Sizing Summary shows wrong unit (temperature)

[jmarrec]

Pull request overview

• Fixes Imperial conversion of coil leaving air humidity ratio in Coil Sizing Summary shows temperature  #7565

• Coil Leaving Air Humidity Ratio in Coil Sizing Summary was using Celsius as unit

  • Images from HTML: Ori (SI), New (SI), New (IP)

• Standardized around kgWater/kgDryAir throughout the code base

• Updated UnitConv accordingly.

• Adding units for Design Inlet/Outlet Air Humidity Ratio in WaterCoils.cc

  • Ori:
    
  • New (SI):
    
  • New (IP):
    

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport: N/A
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label: N/A
• If structural output changes, add to output rules file and add OutputChange label: N/A
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies: N/A

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[nrel-bot-2c]

@jmarrec @lgentile it has been 28 days since this pull request was last updated.

[nrel-bot-2c]

@jmarrec @lgentile it has been 28 days since this pull request was last updated.

[Myoldmopar]

Whoa, I wasn't expecting 32 files changed, but I see now it's heavily just comment changes. There are a few conflicts in some files that got overhauled in the plant refactor. Unless you specifically made functional changes in those files I think the safest thing would just be to accept the develop version of those files and then reapply any comment fixes you made. If you are able to handle that I'm assuming this could drop in.

[mjwitte]

@Myoldmopar I'm actually working on the merge as we speak.

[mjwitte]

Reviewed a few table diffs. Confirmed that defect file is fixed. Unit tests all run. Added an entry in output rules (technically not a structural change but good to highlight this anyway since column headings change). Will merge after CI finishes.

[jmarrec]

Thanks for the review!