Absorption Chiller Plant Component Refactor

[mitchute]

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[mitchute]

Ready for review.

[Myoldmopar]

Note for later, a lot of times these getInput flags aren't actually needed to be defined and exposed via the header file, it can be defined at the top of the cc file only, so just watch out for that on later refactors. Note there are occasions where this isn't actually true, so I'm just throwing this out there.

[mitchute]

@Myoldmopar thanks. This is externed because FaultsManager uses it.

[Myoldmopar]

It might be better to just set this inside the function instead. There are examples of this but I can't think of one at the moment. Basically, in the oneTimeInit function, or the simulate function, get the flow control value off the plant structure:

this->EquipFlowCtrl = DataPlant::PlantLoop(componentLocation.LoopNum).LoopSide(...blah...    .EquipFlowCtrl;

This avoids the dynamic cast.

[mitchute]

@Myoldmopar fixed, and develop is pulled in.

[Myoldmopar]

Always a great sign!

[Myoldmopar]

@mitchute could you comment on my two notes above. If you can address those, and pull develop in, it would be great to get one more clean build and then this can go in.

[Myoldmopar]

Refactors for absorption chiller, indirect absorption chiller, swimming pool, and central GSHP were all merged down locally and tested at once. The only diff was in the indirect, where the missing reset on the variable was causing an expected diff. All four PRs will merge at once here to start clearing the path for CI.