New Schedule for Minimum Airflow for VAV Boxes #7643

Nigusse · 2019-12-05T19:31:50Z

Pull request overview

This is a new feature / enhancement to VAV single and dual duct air terminals.
added a capability to turndown the minimum air flow below the design minimum using new turndown schedule field. The fraction multiplies the design minimum flow rate or the design minimum fraction.
this capability was added to the following single and dual duct VAV air terminals:
- AirTerminal:SingleDuct:VAV:Reheat
- AirTerminal:SingleDuct:VAV:NoReheat
- AirTerminal:SingleDuct:VAV:Reheat:VariableSpeedFan
- AirTerminal:SingleDuct:VAV:HeatAndCool:Reheat
- AirTerminal:SingleDuct:VAV:HeatAndCool:NoReheat
- AirTerminal:DualDuct:VAV

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

Perform a Code Review on GitHub
If branch is behind develop, merge develop and build locally to check for side effects of the merge
If feature, test running new feature, try creative ways to break it
CI status: all green or justified
Check that performance is not impacted (CI Linux results include performance check)
Run Unit Test(s) locally
Check any new function arguments for performance impacts
Verify IDF naming conventions and styles, memos and notes and defaults
If new idf included, locally check the err file and other outputs

mjwitte

@Nigusse This looks good in general. Some comments.

mjwitte · 2019-12-11T19:47:59Z

design/FY2020/NFP-Scheduling-Min-AirFlow-For-VAV-Boxes.md

+       \note values. This field can be used with any of the three "Zone Minimum Air Flow Input Method"   
+       \note Schedule values are fractions, 0.0 to 1.0. This field is intended for use with 
+       \note ASHRAE Standard 170.
+       \note If this field is left blank, then the operating minimum air flow fraction value is set to 1.0


"Operating" is a bit confusing here. Even though the other inputs are the "design" minimum, they also are used for operation, and the existing "Minimum Air Flow Fraction Schedule Name" is primarily operational. It's only used for sizing if the other min flow fields are blank. How about "Minimum Air Flow Turndown Schedule Name" or "Minimum Air Flow Adjustment Schedule Name" or ???

Is this adjustment limited to zero to 1.0? Or would an adjustment >1.0 ever be applicable?

I will use "Minimum Air Flow Turndown Schedule Name" as the new field name but will use "Adjustment" in the description. I am thinking to limit to 0.0 to 1.0. I think users should use the design minimum fraction or the design minimum flow if they desire scale it up.

mjwitte · 2019-12-11T19:50:04Z

design/FY2020/NFP-Scheduling-Min-AirFlow-For-VAV-Boxes.md

+       \note This field is used if the field Zone Minimum Air Flow Input Method is Scheduled
+       \note Schedule values are fractions, 0.0 to 1.0.
+       \note If the field Constant Minimum Air Flow Fraction is blank, then the average of the
+       \note minimum and maximum schedule values is used for sizing normal-action reheat coils.


It needs to be very clear that this schedule will be multiplied by the new schedule. That's a little confusing. I suppose few users would do that, they'd likely just use the new schedule with a fixed minimum here, but one could use both schedules together.

I will try to add more detailed explanation.

mjwitte · 2019-12-11T19:55:13Z

design/FY2020/NFP-Scheduling-Min-AirFlow-For-VAV-Boxes.md

+  SingleDuct.hh
+  Modify struct "SysDesignParams"  to add two new member variables.
+
+    struct SysDesignParams


Feel free to rename this confusing struct SysDesignParams and its associated name Sys.

I will take the liberty to rename the struct when I get there. Thanks.

mjwitte · 2019-12-11T19:56:13Z

design/FY2020/NFP-Scheduling-Min-AirFlow-For-VAV-Boxes.md

+
+  Modify struct "DamperDesignParams"  to add new new member variable
+
+    struct DamperDesignParams


Same here, I've always found DamperDesignParams and Damper to be confusing.

design/FY2020/NFP-Scheduling-Min-AirFlow-For-VAV-Boxes.md

Nigusse · 2020-01-06T22:24:23Z

These variable renaming were suggested during NFP review. Diffs are not expected due to these commits.

Myoldmopar · 2020-01-22T18:11:32Z

@mjwitte you seemed to feel pretty good about this earlier on in the development. You have any lingering concerns? If not then if CI is happy once complete this can merge in.

mjwitte · 2020-01-22T19:40:12Z

@Myoldmopar I took a quick look at just the IDD. That much looks good. I'll defer to you on reviewing the rest of this.

Myoldmopar · 2020-01-22T19:52:28Z

OK, yeah it'll merge as long as Windows doesn't see anything.

Myoldmopar · 2020-01-22T20:58:21Z

@Nigusse I tried to resolve the conflicts in this branch, but they are a little too involved. Can you please pull develop in and resolve them and push back up? Once complete and CI runs again this can go in.

Nigusse · 2020-01-22T21:27:00Z

OK, will do.

…ed conflict

Nigusse · 2020-01-23T13:39:03Z

@Myoldmopar Resolved merge conflict and did cleanup.

Nigusse · 2020-02-10T14:27:41Z

@Myoldmopar working to resolve confclit and will push updated branch shortly after local test.

Myoldmopar · 2020-02-13T22:03:05Z

@Nigusse we've had a lot of activity today and it has resulted in some conflicts here. I think they are primarily related to the uncontrolled terminal PR. Can you please take a look at the conflicts, and if you have trouble, @mjwitte or I can help get things back in shape. Thanks!

Nigusse · 2020-02-13T22:26:14Z

@Myoldmopar Sure, I am working on it. It will be done first thing in the morning.

…resolved conflict

Nigusse · 2020-02-14T13:56:07Z

@Myoldmopar @mjwitte Merged develop into the branch and resolved conflicts.

Nigusse · 2020-02-14T13:57:14Z

Run unit test suite locally and all passed.

Nigusse · 2020-02-14T15:07:54Z

@mjwitte I am seeing audit diffs that I was not expecting. Comparing this branch to develop I see the following four output variables that must have been removed from develop for "AirTerminal:SingleDuct:ConstantVolume:NoReheat" object:

"Zone Air Terminal Sensible Heating Energy"
"Zone Air Terminal Sensible Cooling Energy"
"Zone Air Terminal Sensible Heating Rate"
"Zone Air Terminal Sensible Cooling Rate"

Would you please confirm?

mjwitte · 2020-02-14T15:18:20Z

src/EnergyPlus/SingleDuct.cc

+            SetupOutputVariable(
+                "Zone Air Terminal Sensible Heating Rate", OutputProcessor::Unit::W, sd_airterminal(SysNum).HeatRate, "System", "Average", sd_airterminal(SysNum).SysName);
+            SetupOutputVariable(
+                "Zone Air Terminal Sensible Cooling Rate", OutputProcessor::Unit::W, sd_airterminal(SysNum).CoolRate, "System", "Average", sd_airterminal(SysNum).SysName);


@Nigusse These were removed because they duplicate the same outputs that are already set up by the air distribution unit here.

@mjwitte Thanks. I will correct in this branch and push again.

…-Min-AirFlow-For-VAV-Boxes

mjwitte

@Nigusse I've pushed up a few minor text edits. I've run unit tests locally - all good. I've tested the new schedule with VAVSingleDuctReheat.idf - and it works.

There is no new example file for this. I'm not going to hold this up for that, but we need this somewhere in the testfiles. Perhaps there is an appropriate existing file to add this to (one that would correspond to applying ASHRAE Std 170).

Assuming CI comes back clean, I'll merge this soon.

mjwitte · 2020-02-14T23:07:10Z

@Nigusse Also - have you tested this with each of the affected terminal unit types?

Nigusse · 2020-02-16T20:37:13Z

@mjwitte Yes, I have tested each combination. Also each combination has appropriate unit test. We can always add this new schedule field to selected existing test files.

NFP-Scheduling-Min-AirFlow-For-VAV-Boxes

aef6883

Nigusse added the NewFeature Includes code to add a new feature to EnergyPlus label Dec 5, 2019

Nigusse added 3 commits December 10, 2019 08:37

Added Design Documentation section to the NFP

ecb4dcb

Merge branch 'develop' into Scheduling-Min-AirFlow-For-VAV-Boxes

4b20146

Updated Design Documentation Section of the NFP

4e18f8f

mjwitte reviewed Dec 11, 2019

View reviewed changes

Nigusse and others added 14 commits December 12, 2019 09:03

Updated NFP based on review comments

930a045

Merge branch 'develop' into Scheduling-Min-AirFlow-For-VAV-Boxes

5c110e7

Updated I/O Ref Section of the NFP

1b83569

Moved single and dual duct functions as member

6ac20a9

Merge branch 'develop' into Scheduling-Min-AirFlow-For-VAV-Boxes

37d653f

Moved single and dual duct functions as member

c259df4

Merge branch 'develop' into Scheduling-Min-AirFlow-For-VAV-Boxes

d3c1d56

renamed SysDesignParams with SingleDuctAirTerminal

77e75d2

renamed Sys with sd_airterminal

491c6ae

renamed DamperDesignParams with DualDuctAirTerminal

bdff471

renamed Damper with dd_airterminal

d522f74

renamed single and dual duct variables

4b80836

Merge branch 'develop' into Scheduling-Min-AirFlow-For-VAV-Boxes

8e9509f

More variable rename

caaf7a7

nigusse added 9 commits January 8, 2020 13:27

allowed min flow turndown for VAV Reheat terminal

1b53b4e

allowed min flow turndown for VAV No Reheat terminal

bfc5ef7

allowed min flow turndown for VAV CoolHeat terminal

cce70cb

allowed min flow turndown for VAV Reheat VSFan terminal

5608d51

Merge branch 'develop' into Scheduling-Min-AirFlow-For-VAV-Boxes

186eb21

allowed min flow turndown for VAV DualDuct terminal

c01f579

One more fix and and cleanup

5178644

Merge branch 'develop' into Scheduling-Min-AirFlow-For-VAV-Boxes

b019bfb

added unit test for VAV air terminals

e62ee6f

nigusse added 3 commits January 23, 2020 08:26

Merged 'develop' into Scheduling-Min-AirFlow-For-VAV-Boxes and resolv…

e005a98

…ed conflict

Merge branch 'develop' into Scheduling-Min-AirFlow-For-VAV-Boxes

937604e

Merge conflict cleanup

8680e3d

Merge branch 'develop' into Scheduling-Min-AirFlow-For-VAV-Boxes

fc0a00d

Merge branch 'develop' into Scheduling-Min-AirFlow-For-VAV-Boxes and …

e4184c6

…resolved conflict

mjwitte reviewed Feb 14, 2020

View reviewed changes

nigusse and others added 4 commits February 14, 2020 10:23

Removed output variables from merge conflicts

47650a9

Merge remote-tracking branch 'remotes/origin/develop' into Scheduling…

57ab372

…-Min-AirFlow-For-VAV-Boxes

Merge remote-tracking branch 'remotes/origin/develop' into Scheduling…

9319a01

…-Min-AirFlow-For-VAV-Boxes

Schedule vav min flow - minor text edits

296b6dc

mjwitte approved these changes Feb 14, 2020

View reviewed changes

mjwitte changed the title ~~Scheduling Minimum Airflow for VAV Boxes~~ New Schedule for Minimum Airflow for VAV Boxes Feb 14, 2020

Schedule vav min flow - format AirTerminalSingleDuct.unit.cc

25e0b3a

mjwitte merged commit c771fa8 into develop Feb 16, 2020

mjwitte deleted the Scheduling-Min-AirFlow-For-VAV-Boxes branch February 16, 2020 04:33

Nigusse mentioned this pull request Feb 26, 2020

Add new example file for VAV Box Minimum Air Flow turndown schedule use #7816

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Schedule for Minimum Airflow for VAV Boxes #7643

New Schedule for Minimum Airflow for VAV Boxes #7643

Nigusse commented Dec 5, 2019 •

edited by mjwitte

Loading

mjwitte left a comment

mjwitte Dec 11, 2019

Nigusse Dec 12, 2019

mjwitte Dec 11, 2019

Nigusse Dec 12, 2019

mjwitte Dec 11, 2019

Nigusse Dec 12, 2019

mjwitte Dec 11, 2019

Nigusse Dec 12, 2019

Nigusse commented Jan 6, 2020

Myoldmopar commented Jan 22, 2020

mjwitte commented Jan 22, 2020

Myoldmopar commented Jan 22, 2020

Myoldmopar commented Jan 22, 2020

Nigusse commented Jan 22, 2020

Nigusse commented Jan 23, 2020

Nigusse commented Feb 10, 2020

Myoldmopar commented Feb 13, 2020

Nigusse commented Feb 13, 2020

Nigusse commented Feb 14, 2020

Nigusse commented Feb 14, 2020

Nigusse commented Feb 14, 2020

mjwitte Feb 14, 2020

Nigusse Feb 14, 2020 •

edited

Loading

mjwitte left a comment

mjwitte commented Feb 14, 2020

Nigusse commented Feb 16, 2020


		Modify struct "DamperDesignParams" to add new new member variable

		struct DamperDesignParams

New Schedule for Minimum Airflow for VAV Boxes #7643

New Schedule for Minimum Airflow for VAV Boxes #7643

Conversation

Nigusse commented Dec 5, 2019 • edited by mjwitte Loading

Pull request overview

Pull Request Author

Reviewer

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nigusse commented Jan 6, 2020

Myoldmopar commented Jan 22, 2020

mjwitte commented Jan 22, 2020

Myoldmopar commented Jan 22, 2020

Myoldmopar commented Jan 22, 2020

Nigusse commented Jan 22, 2020

Nigusse commented Jan 23, 2020

Nigusse commented Feb 10, 2020

Myoldmopar commented Feb 13, 2020

Nigusse commented Feb 13, 2020

Nigusse commented Feb 14, 2020

Nigusse commented Feb 14, 2020

Nigusse commented Feb 14, 2020

Choose a reason for hiding this comment

Nigusse Feb 14, 2020 • edited Loading

Choose a reason for hiding this comment

mjwitte left a comment

Choose a reason for hiding this comment

mjwitte commented Feb 14, 2020

Nigusse commented Feb 16, 2020

Nigusse commented Dec 5, 2019 •

edited by mjwitte

Loading

Nigusse Feb 14, 2020 •

edited

Loading