Chiller Electric Reformulated EIR Plant Component Refactor

[mitchute]

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[Myoldmopar]

Yep, back to purely text-diffs. Feel free to commit the CondOutletTemp change again now so CI will demonstrate the diffs and we can clearly point the finger at that one variable change. Then we'll all feel better understanding that it's just a bug-fix.

[Myoldmopar]

It looks like there are a couple things going on that could cause the diff. Is it due to the removal of the RefEIRReport instance? Or the module level variable? Are you able to split out which is the root cause? It could make it even easier to digest the diff and verify we understand the implications. I feel like in the end it's going to be found that the root problem was that a temp was not properly updated on every return path, but I'd like to see if we can nail down the exact line or code path that is causing it. It may even help resolve #7680

[Myoldmopar]

Deleted the results to re-run Windows on that last commit.

[mitchute]

The most recent commits are comment- or style-only changes. The results from the most recent CI runs should be valid.

[Myoldmopar]

Thanks @mitchute. I am only like 99.8% confident in the automagic of clang-format, so I'll let CI have a pass over it to be sure. Then I'll merge this in.

[Myoldmopar]

OK, @nrel-bot is taking forever, but this is good enough for me. The last commit was cleanup only so I really just needed to see one platform. Anyway, merging this in; thanks for all the effort on the plant refactor, @mitchute !