Remove objexx gio 4 #7727
Merged
Remove objexx gio 4 #7727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Myoldmopar I don't know why the Windows build failed to post to CI, but I do have a potential E+ error on Windows I need to investigate. FYI |
|
@Myoldmopar the error is a floating point underflow that happens in debug builds with a few models. Doesn't seem to be related to any changes I made. |
|
This looks great. EIO diffs are legitimate bug fixes. It's up to date with |
Myoldmopar
added
the
Refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Phase four of objexx gio removal.
Focuses only on InternalHeatGains.cc due to the number of changes.
Note that this reduced the file by ~500LOC
The two EIO diffs are clear bug fixes compared to the original file (adding a missing
,specifically)