Fix formatting warnings and also formatting checker #7778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Myoldmopar
added
the
DoNotPublish
20 tasks
|
@Myoldmopar fix verified on Linux. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting warnings were just because tabs were found in a unit test file. These are fixed here.
I found that the format checker was reporting out messages to CI, but using "filename" instead of just "file". I fixed that here as well, and now it should properly point developers to the exact line that was problematic.
Reviewer: If you want to run this locally, just make sure you have clang-format installed, and from the root of the repository, run
./scripts/dev/verify_formatting.sh. It shouldn't report anything. Then add a tab character to a src or tst file and re-run. It should report a JSON warning about the character.