Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate input in AirflowNetwork:Distribution:Node #7798

Merged
merged 7 commits into from
Mar 10, 2020

Conversation

lgu1234
Copy link
Contributor

@lgu1234 lgu1234 commented Feb 21, 2020

Pull request overview

Check duplicated inputs of Component Name or Node Name in AirflowNetwork:Distribution:Node and issue an error
Provide a test file
Correct inputs in 7 example files
No differences were found in 7 example files on local computer

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@lgu1234 lgu1234 added the Defect Includes code to repair a defect in EnergyPlus label Feb 27, 2020
@jasondegraw
Copy link
Member

@lgu1234 Is this PR ready for review?

@lgu1234
Copy link
Contributor Author

lgu1234 commented Feb 28, 2020

@jasondegraw Yes. It is ready for review. Thanks.

Copy link
Member

@jasondegraw jasondegraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This corrects the issue, looks good to go.

@jasondegraw jasondegraw added this to the EnergyPlus 9.3.0 milestone Feb 28, 2020
@lgu1234
Copy link
Contributor Author

lgu1234 commented Feb 28, 2020

@jasondegraw A failure of unit test was fixed.

@mitchute mitchute linked an issue Mar 10, 2020 that may be closed by this pull request
3 tasks
@mitchute
Copy link
Collaborator

Unit tests pass on this locally. @lgu1234 anything else you're wanting to do here before final review and merge?

@lgu1234
Copy link
Contributor Author

lgu1234 commented Mar 10, 2020

@mitchute No. Please merge.

@mitchute mitchute merged commit 7f2b69b into develop Mar 10, 2020
@mitchute mitchute deleted the 171381603-Issue7762 branch March 10, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node duplication in some of the AirflowNetwork example files
8 participants