-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate input in AirflowNetwork:Distribution:Node #7798
Conversation
@lgu1234 Is this PR ready for review? |
@jasondegraw Yes. It is ready for review. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This corrects the issue, looks good to go.
@jasondegraw A failure of unit test was fixed. |
Unit tests pass on this locally. @lgu1234 anything else you're wanting to do here before final review and merge? |
@mitchute No. Please merge. |
Pull request overview
Check duplicated inputs of Component Name or Node Name in AirflowNetwork:Distribution:Node and issue an error
Provide a test file
Correct inputs in 7 example files
No differences were found in 7 example files on local computer
NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.