Fix file name in path returned by getAbsolutePath when a directory is not provided

[nealkruis]

Pull request overview

• Fixes getAbsolutePath strips characters from the file name #8329

This fixes getAbsolutePath for two scenarios:

1. When a file was specified in the current working directory (e.g., with no directory prefixes), the file name returned in the path had the first two characters stripped off. E.g.:

   getAbsolutePath("FileSystemTest.idf") = "/Path/to/cwd/leSystemTest.idf"
   

2. After an initial fix for (1), I noticed:

   getAbsolutePath("./FileSystemTest.idf") = "/Path/to/cwd/./FileSystemTest.idf"
   

This pull requests includes unit tests for both of these situations and they now both come out correctly:

"/Path/to/cwd/FileSystemTest.idf"

The fix and unit tests use the platform independent value of DataStringGlobals::pathChar.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts

[nrel-bot-2]

@nealkruis @lgentile it has been 28 days since this pull request was last updated.

[mitchute]

@nealkruis this looks good. I ran tests locally and it all looked OK. Merging.