Various DX coil fixes #8576

mjwitte · 2021-03-02T00:22:24Z

Pull request overview

This contains various fixes related to the old DX coils taken from the Coil:DX:Cooling work.
Use PLR, not RuntimeFraction to calculate leaving conditions for 2-stage operation (Coil:Cooling:DX:TwoStageWithHumidityControlMode).
Fix Multispeed DX massflow weighting between speeds (Coil:Cooling:DX:Multispeed)
Fix Multispeed DX outlet conditions at low speed (Coil:Cooling:DX:Multispeed)
Allow 2-speed DX to operate as variable speed (Coil:Cooling:DX:TwoSpeed)

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
If any diffs are expected, author must demonstrate they are justified using plots and descriptions
If changes fix a defect, the fix should be demonstrated in plots and descriptions
If any defect files are updated to a more recent version, upload new versions here or on DevSupport

Reviewer

This will not be exhaustively relevant to every PR.

…neOldCoilFixes

mjwitte

Code walkthru. Note that UnitarySystem changes overlap (duplicate?) changes in #8558.

mjwitte · 2021-03-05T21:14:25Z

src/EnergyPlus/DXCoils.cc

-                        (1.0 - S12RuntimeFraction) * S1OutletAirEnthalpy + S12RuntimeFraction * S12OutletAirEnthalpy;
-                    state.dataDXCoils->DXCoil(DXCoilNum).OutletAirHumRat = (1.0 - S12RuntimeFraction) * S1OutletAirHumRat + S12RuntimeFraction * S12OutletAirHumRat;
+                        (1.0 - S2PLR) * S1OutletAirEnthalpy + S2PLR * S12OutletAirEnthalpy;
+                    state.dataDXCoils->DXCoil(DXCoilNum).OutletAirHumRat = (1.0 - S2PLR) * S1OutletAirHumRat + S2PLR * S12OutletAirHumRat;


Use PLR, not RuntimeFraction to calculate leaving conditions for 2-stage operation (Coil:Cooling:DX:TwoStageWithHumidityControlMode). RuntimeFraction is appropriate for power consumption.

mjwitte · 2021-03-05T21:23:49Z

src/EnergyPlus/DXCoils.cc

-                    if (FanOpMode == ContFanCycCoil) {
-                        Real64 MinAirHumRat(0.0); // set to zero because MinAirHumRat is unused argument
-                        Hfg = PsyHfgAirFnWTdb(MinAirHumRat, HSOutletAirDryBulbTemp * SpeedRatio + (1.0 - SpeedRatio) * LSOutletAirDryBulbTemp);
-                        // Average outlet HR
-                        OutletAirHumRat = InletAirHumRat - state.dataDXCoils->DXCoil(DXCoilNum).LatCoolingEnergyRate / Hfg / state.dataDXCoils->DXCoil(DXCoilNum).InletAirMassFlowRate;
-                    } else {
-                        OutletAirHumRat = (HSOutletAirHumRat * SpeedRatio) + (LSOutletAirHumRat * (1.0 - SpeedRatio));
-                    }
+                    OutletAirHumRat =
+                        ((HSOutletAirHumRat * SpeedRatio * MSHPMassFlowRateHigh) + (LSOutletAirHumRat * (1.0 - SpeedRatio) * MSHPMassFlowRateLow)) /
+                        state.dataDXCoils->DXCoil(DXCoilNum).InletAirMassFlowRate;


Multispeed DX fix massflow weighting between speeds (2398ce6)

I recall this from @lgu1234 a while back.

mjwitte · 2021-03-05T21:27:13Z

src/EnergyPlus/DXCoils.cc

+                // Now reset runtime fraction to 1.0 (because LS is running the full timestep)
+                state.dataDXCoils->DXCoil(DXCoilNum).CoolingCoilRuntimeFraction = 1.0;


This inside a big if (SpeedNum > 1 && SingleMode == 0) { so this means it running at speed 2 or higher. (bd8aa38)

Makes sense.

mjwitte · 2021-03-05T21:30:22Z

src/EnergyPlus/DXCoils.cc

-                OutletAirHumRat = LSOutletAirHumRat;
-                OutletAirDryBulbTemp = LSOutletAirDryBulbTemp;
+                if (FanOpMode == ContFanCycCoil) {
+                    // outlet conditions are average of inlet and low speed weighted by CycRatio


Multispeed DX fix outlet conditions at low speed (bd8aa38)

I see in here where OutletAir* variables are calculated. Oh, there it is, in the else they are also set for cycling fan. OK then.

mjwitte · 2021-03-05T21:35:10Z

src/EnergyPlus/UnitarySystem.cc

-        } else if (this->m_CoolingCoilType_Num == DataHVACGlobals::CoilDX_MultiSpeedCooling) {
+        } else if (this->m_CoolingCoilType_Num == DataHVACGlobals::CoilDX_MultiSpeedCooling ||
+                   this->m_CoolingCoilType_Num == DataHVACGlobals::CoilDX_CoolingTwoSpeed) {


Allow 2-speed dx to have variable speeds (ea02126)

This is actually missing from develop? And now things line up better?

@rraustad You actually made this commit a year ago. ea02126 Ring a bell?

No, but at least I'm consistent. And that whole conversation of what does idle speed anything mean is still a little confusing. I see now there is a call to DXCoils::SimDXCoilMultiSpeed. That is the correct call for 2-spd coil? I've lost track but thought is was a different function.

Yes, that's fine. There are further checks on coil type in that function.
line 343 if (SELECT_CASE_var == CoilDX_CoolingTwoSpeed) {

mjwitte · 2021-03-05T21:45:55Z

src/EnergyPlus/UnitarySystem.cc

@@ -2179,6 +2180,15 @@ namespace UnitarySystems {
                this->m_IdleVolumeAirRate = this->m_MaxNoCoolHeatAirVolFlow;
                this->m_IdleMassFlowRate = this->MaxNoCoolHeatAirMassFlow;
                this->m_IdleSpeedRatio = this->m_IdleVolumeAirRate / this->m_DesignFanVolFlowRate;
+            } else {
+                for ( Iter = this->m_NumOfSpeedCooling; Iter > 0; --Iter ) {
+                    this->m_CoolVolumeFlowRate[ Iter ] = this->m_MaxCoolAirVolFlow * Iter / this->m_NumOfSpeedCooling;


More allow 2-speed dx to be variable speed (ea02126)

and this goes with the 2-speed coil addition to this section.

mjwitte · 2021-03-05T21:47:07Z

src/EnergyPlus/UnitarySystem.cc

@@ -4414,7 +4424,13 @@ namespace UnitarySystems {

                        } else { // mine data from DX cooling coil

-                            if (thisSys.m_CoolingCoilType_Num == DataHVACGlobals::CoilDX_CoolingTwoSpeed) thisSys.m_NumOfSpeedCooling = 2;
+                            if (thisSys.m_CoolingCoilType_Num == DataHVACGlobals::CoilDX_CoolingTwoSpeed) {


More allow 2-speed dx to be variable speed (ea02126)

rraustad · 2021-03-17T18:48:30Z

src/EnergyPlus/DXCoils.cc

-                                                          state.dataDXCoils->DXCoil(DXCoilNum).TotalCoolingEnergyRate);
-                    }
-                }
+


The above deleted code looks like it's catching up to develop.

rraustad · 2021-03-17T19:14:13Z

src/EnergyPlus/UnitarySystem.cc

@@ -7286,6 +7290,7 @@ namespace UnitarySystems {
                }

                if (state.dataUnitarySystems->unitarySys[sysNum].m_CoolingCoilType_Num == DataHVACGlobals::CoilDX_MultiSpeedCooling ||
+                    state.dataUnitarySystems->unitarySys[sysNum].m_CoolingCoilType_Num == DataHVACGlobals::CoilDX_CoolingTwoSpeed ||
                    state.dataUnitarySystems->unitarySys[sysNum].m_CoolingCoilType_Num == DataHVACGlobals::CoilDX_Cooling ||
                    state.dataUnitarySystems->unitarySys[sysNum].m_HeatingCoilType_Num == DataHVACGlobals::CoilDX_MultiSpeedHeating ||
                    state.dataUnitarySystems->unitarySys[sysNum].m_HeatingCoilType_Num == DataHVACGlobals::Coil_HeatingElectric_MultiStage ||


I see, you moved the report variable set up to here (but didn't get rid of the "if" in above code at 7207).

Good catch - will clean that up.

rraustad · 2021-03-17T19:20:31Z

src/EnergyPlus/UnitarySystem.cc

@@ -9077,7 +9082,10 @@ namespace UnitarySystems {
        // RETURN if the moisture load is met
        if (state.dataUnitarySystems->MoistureLoad >= 0.0 || state.dataUnitarySystems->MoistureLoad >= TempLatOutput) return;
        // Multimode does not meet the latent load, only the sensible load with or without HX active
+         // what if there is a heating load for a system using Multimode?


May need to create a new issue to see if this works as expected.

rraustad · 2021-03-17T19:21:59Z

tst/EnergyPlus/unit/UnitarySystem.unit.cc

    Real64 totalAncillaryPower =
        thisSys->m_AncillaryOnPower * thisSys->m_PartLoadFrac + thisSys->m_AncillaryOffPower * (1.0 - thisSys->m_PartLoadFrac);
    EXPECT_NEAR(totalAncillaryPower, thisSys->m_TotalAuxElecPower, 0.00000001);
    // at PLR very near 0.5, m_TotalAuxElecPower should be very near 75 W.
-    EXPECT_NEAR(74.694, thisSys->m_TotalAuxElecPower, 0.0001);
+    EXPECT_NEAR(74.4036, thisSys->m_TotalAuxElecPower, 0.0001);


small diff's in unit tests, good to go so far.

…neOldCoilFixes

mjwitte · 2021-03-17T22:09:34Z

@rraustad Thanks for the review.

Myoldmopar · 2021-03-17T22:11:18Z

@mjwitte my global branch is about to merge. I don't anticipate major conflicts with this branch. I believe @mitchute also has another globals branch soon to be ready to merge. After that I'm back to trying to get the other PRs reviewed and merged for a little while, then more globals tomorrow afternoon. All that to say, if any more conflicts arise, I'm happy to resolve them. 👍

mjwitte · 2021-03-17T22:16:03Z

@Myoldmopar Much appreciated. I'm done with this for the time being. I have not looked at the diffs to make sure there's nothing ridiculous in here.

Myoldmopar · 2021-03-22T00:53:52Z

Pulled develop in, there was only a tiny conflict even after all those PRs. I ran the unit test suite, and I am starting to see some SQL related unit tests fail, but they only seem to be happening when the unit tests are run serially, and it's not consistent. I don't have time to investigate right now, so I'm just going to pretend for tonight like they aren't happening.

I'll run the regressions locally, and assuming CI is OK with my merge I'll take a peek into the diffs and we'll see if we can drop this right in tomorrow morning, then follow it up with the other coil branch.

Myoldmopar · 2021-03-22T13:21:59Z

I am able to reproduce the diffs locally as they are on CI.

EIO diffs: Warmup convergence, tiny
ERR diffs: Reduced hvac iteration warnings
Table diffs: Small changes in peak electricity usage, generally < 1%
ESO diffs: Values generally changed on the order of e-8, unitary system electricity off by ~1%
MTR diffs: HVAC electricity off by less than 1%

I took the big diff math files and re-ran them with only annual results and got zero out of range math diffs. I believe this is good to go in. Thanks @mjwitte and @rraustad ! This is great!

mjwitte added 2 commits March 1, 2021 17:00

Old coil fixes from DX coil baseline

874c161

Merge remote-tracking branch 'remotes/origin/develop' into CoilBaseli…

28a7ec4

…neOldCoilFixes

mjwitte changed the title ~~Various (old) DX coil fixes~~ Various DX coil fixes Mar 2, 2021

mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Mar 2, 2021

mjwitte added this to the EnergyPlus 9.5.0 milestone Mar 2, 2021

mjwitte mentioned this pull request Mar 3, 2021

Coil:Cooling:DX updates #8558

Merged

25 tasks

mjwitte added 3 commits March 5, 2021 14:37

Merge remote-tracking branch 'remotes/origin/develop' into CoilBaseli…

cdf4f01

…neOldCoilFixes

Coil baseline - fix build warning

f0e1049

Merge remote-tracking branch 'remotes/origin/develop' into CoilBaseli…

1d5e5f3

…neOldCoilFixes

mjwitte marked this pull request as ready for review March 5, 2021 21:08

mjwitte commented Mar 5, 2021

View reviewed changes

mjwitte added 2 commits March 5, 2021 16:05

Coil baseline - remove duplicate unitary outputs

23573fd

Coil baseline - harmonize unit test with multi-speed dx changes

6c67173

rraustad reviewed Mar 17, 2021

View reviewed changes

mjwitte added 3 commits March 17, 2021 16:26

Merge remote-tracking branch 'remotes/origin/develop' into CoilBaseli…

3116874

…neOldCoilFixes

Coil baseline - remove dead if

77ee3ad

Coil baseline - merge cleanup

b118f24

Merge develop; resolve tiny conflict

9d534e2

Myoldmopar merged commit f1a13ce into develop Mar 22, 2021

Myoldmopar deleted the CoilBaselineOldCoilFixes branch March 22, 2021 13:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various DX coil fixes #8576

Various DX coil fixes #8576

mjwitte commented Mar 2, 2021 •

edited

Loading

mjwitte left a comment

mjwitte Mar 5, 2021

rraustad Mar 17, 2021

mjwitte Mar 5, 2021

rraustad Mar 17, 2021

mjwitte Mar 5, 2021

rraustad Mar 17, 2021

mjwitte Mar 5, 2021

rraustad Mar 17, 2021

mjwitte Mar 5, 2021

rraustad Mar 17, 2021

mjwitte Mar 17, 2021

rraustad Mar 17, 2021

mjwitte Mar 17, 2021

mjwitte Mar 5, 2021

rraustad Mar 17, 2021

mjwitte Mar 5, 2021

rraustad Mar 17, 2021

rraustad Mar 17, 2021

mjwitte Mar 17, 2021

rraustad Mar 17, 2021

rraustad Mar 17, 2021

mjwitte commented Mar 17, 2021

Myoldmopar commented Mar 17, 2021

mjwitte commented Mar 17, 2021

Myoldmopar commented Mar 22, 2021

Myoldmopar commented Mar 22, 2021

		// Now reset runtime fraction to 1.0 (because LS is running the full timestep)
		state.dataDXCoils->DXCoil(DXCoilNum).CoolingCoilRuntimeFraction = 1.0;

Various DX coil fixes #8576

Various DX coil fixes #8576

Conversation

mjwitte commented Mar 2, 2021 • edited Loading

Pull request overview

Pull Request Author

Reviewer

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte commented Mar 17, 2021

Myoldmopar commented Mar 17, 2021

mjwitte commented Mar 17, 2021

Myoldmopar commented Mar 22, 2021

Myoldmopar commented Mar 22, 2021

mjwitte commented Mar 2, 2021 •

edited

Loading