Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HVAC Sizing Summary Thermostat Setpoint Temperature at Peak Load when no peak heating load #8742

Merged
merged 46 commits into from
Sep 20, 2021
Merged

Fix HVAC Sizing Summary Thermostat Setpoint Temperature at Peak Load when no peak heating load #8742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
3700b05
Attempted fixes for reporting thermostat setpoint with no heating pea…
matthew-larson Apr 1, 2021
239bb3a
Fix merge conflicts.
matthew-larson Apr 7, 2021
7d97b53
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson Apr 20, 2021
12494e9
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson Apr 29, 2021
26edd2e
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson Apr 30, 2021
9af1afc
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson Apr 30, 2021
14062de
Add thermostat setpoint temperature at peak heating if no heating exi…
matthew-larson Apr 30, 2021
1d1518b
Add line for CoolTstatTemp as well.
matthew-larson May 4, 2021
b559701
Add unit test for issue.
matthew-larson May 4, 2021
aaf5c67
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson May 4, 2021
497b034
Updates for adding peak date/time even with no load.
matthew-larson May 21, 2021
587882e
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson May 21, 2021
9367268
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson May 27, 2021
5b532c9
Update to include min difference in temp if no load.
matthew-larson May 29, 2021
7505f25
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson May 29, 2021
0a4b230
Add comments to added sections.
matthew-larson May 31, 2021
ce2f907
Update code to pull zone temp at peaks and thermostat setpoint when t…
matthew-larson Jun 2, 2021
3be28ea
Fix clang formatting.
matthew-larson Jun 2, 2021
4aa9258
Update unit test based on updated fix.
matthew-larson Jun 2, 2021
4e35e30
Fix clang formatting.
matthew-larson Jun 2, 2021
1d82aa0
Update SingleDuct unit test based on updated ZoneTempAtHeatPeak value.
matthew-larson Jun 2, 2021
0e51fce
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson Jun 23, 2021
6c818e9
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson Jul 1, 2021
96637eb
Updates for no load sizing data
matthew-larson Jul 15, 2021
777b4b7
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson Jul 15, 2021
e6d7313
Fix clang format
matthew-larson Jul 15, 2021
740e717
Merge develop.
matthew-larson Jul 21, 2021
d4dac58
Update logic for consistency.
matthew-larson Jul 21, 2021
d535aa8
Update unit test and failed unit test.
matthew-larson Jul 21, 2021
8ee3054
Fix clang formatting.
matthew-larson Jul 21, 2021
ed984f5
Fix merge conflicts.
matthew-larson Sep 2, 2021
431cc0d
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson Sep 10, 2021
c8bcf15
Modify for correct system sizing.
matthew-larson Sep 10, 2021
35cefe1
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson Sep 13, 2021
94a2ee6
Remove else if statement for thermostat temp. Was modifying sizing i…
matthew-larson Sep 13, 2021
03f9ef3
Add else if and else block back in to TstatTemp.
matthew-larson Sep 14, 2021
4dc42a4
Updates, work in progress.
matthew-larson Sep 16, 2021
7e40949
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson Sep 17, 2021
0390766
Fix finalsizing parameters.
matthew-larson Sep 17, 2021
347ff30
Minor adjustments and fix unit test.
matthew-larson Sep 17, 2021
ed0b350
Fix unit test.
matthew-larson Sep 17, 2021
162e3c4
Add logic to satisfy unit tests and revert old unit test back.
matthew-larson Sep 17, 2021
ed65a50
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson Sep 17, 2021
2787eef
Correct unit test comments.
matthew-larson Sep 17, 2021
eb1d925
Minor fix.
matthew-larson Sep 18, 2021
2ef6f18
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into fix…
matthew-larson Sep 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading