Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EnergyPlus-generated RVI and MVI use non-quoted paths #8841

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

mitchute
Copy link
Collaborator

@mitchute mitchute commented Jun 24, 2021

Pull request overview

Fixes #8840

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mitchute mitchute added the Defect Includes code to repair a defect in EnergyPlus label Jun 24, 2021
@mitchute mitchute added this to the EnergyPlus 9.6 Release milestone Jun 24, 2021
@mitchute mitchute requested a review from jmarrec June 24, 2021 16:39
@mitchute mitchute self-assigned this Jun 24, 2021
@mitchute mitchute changed the title Make EnergyPlus-generated RVI and MVI used non-quoted paths Make EnergyPlus-generated RVI and MVI use non-quoted paths Jun 24, 2021
@@ -883,8 +883,8 @@ namespace CommandLineInterface {
if (!ofs.good()) {
ShowFatalError(state, "EnergyPlus: Could not open file \"" + RVIfile.string() + "\" for output (write).");
} else {
ofs << state.files.eso.filePath << '\n';
ofs << state.files.csv.filePath << '\n';
ofs << state.files.eso.filePath.string() << '\n';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. ostream operator<< with a filesystem path will double quote the path. Moving to the string overload alleviates the problem.

@mitchute
Copy link
Collaborator Author

Thanks for the review, @jmarrec! Merging.

@mitchute mitchute merged commit ccad7dd into develop Jun 29, 2021
@mitchute
Copy link
Collaborator Author

FYI @Myoldmopar @jmarrec

  ================ RUNNING XELATEX THE FIRST TIME =====================
  xelatex: security risk: running with elevated privileges
  This is XeTeX, Version 3.141592653-2.6-0.999993 (MiKTeX 21.6.28)
  initexmf: security risk: running with elevated privileges
  
  Sorry, but "MiKTeX Configuration Utility" did not succeed for the following reason:
  
    MiKTeX could not remove the file 'C:\Users\runneradmin\AppData\Local\MiKTeX\miktex\data\le\df2c24cb21984fa85003c1ecc818ff83.fndb-5'.
  
  Remedy:
  
    Close running MiKTeX programs and try again.

I don't think it's related to this PR. Also, have you tried turning GHA off and on again?

@mitchute mitchute deleted the fix-readvars-errors branch July 28, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadVarsESO Fails when RVI and MVI missing
6 participants