Correct Input Logic for Autosized Cooling Only Variable Flow Low Temperature Radiant

[RKStrand]

Pull request overview

• Fixes ZoneHVAC:LowTemperatureRadiant:VariableFlow input processing problem for cooling only configuration #8885
• When autosizing a cooling only variable flow low temperature radiant system, a severe warning would be thrown that indicated something was wrong with the input. Upon inspection, there were two typos in the code that were checking the wrong parameters (for heating rather than cooling) to see if they were blank. Since it was a cooling only system, the heating nodes were blank and this triggered a severe error falsely. This typo was corrected with the appropriate input fields and a unit test was created specifically to show that this combination no longer throws an error. No documentation changes were needed as this is simply a typo in the code and doesn't change anything about the design of the input.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[Myoldmopar]

Building and running this locally.

[Myoldmopar]

All good here, merging. Thanks @RKStrand