Remove duplicate code with surface reference air temperature

[matthew-larson]

Pull request overview

• Fixes #
• This pull request eliminates duplicate sections of code where the surface reference air temperature was being calculated in multiple places. It turns out there was a function already created for this calculation in DataSurfaces.cc called SurfaceData::getInsideAirTemperature. The duplicate code was replaced with this function for calculating surface reference air temperature in all the locations.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally

[mitchute]

I merged this up with develop locally and tested 50 random regression files, which showed zero diffs. Unit tests all ran serially. The PR looks OK to me. @matthew-larson could you pull in develop one more time?

@mjwitte @rraustad you might want to take a quick look around here.

[mitchute]

Looks like @nrel-bot is back from vacation and we finally have Windows results here. This is ready. Merging.

[matthew-larson]

Thanks @mitchute!