Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9022 - conversion should respect outDirPath #9023

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

jmarrec
Copy link
Contributor

@jmarrec jmarrec commented Aug 30, 2021

Pull request overview

Fix #9022 - conversion should respect outDirPath

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jmarrec jmarrec added the Defect Includes code to repair a defect in EnergyPlus label Aug 30, 2021
@jmarrec jmarrec requested a review from Myoldmopar August 30, 2021 12:17
@jmarrec jmarrec self-assigned this Aug 30, 2021
jmarrec added a commit to NREL/OpenStudio that referenced this pull request Aug 30, 2021
@jmarrec jmarrec added this to the EnergyPlus 9.6 Release milestone Aug 30, 2021
@@ -299,7 +299,7 @@ void InputProcessor::processInput(EnergyPlusData &state)
input_file = epJSONClean.dump(4, ' ', false, json::error_handler_t::replace);
// input_file = epJSON.dump(4, ' ', false, json::error_handler_t::replace);
fs::path convertedIDF = FileSystem::makeNativePath(
FileSystem::replaceFileExtension(state.dataStrGlobals->outputDirPath / state.dataStrGlobals->inputFilePathNameOnly, ".epJSON"));
FileSystem::replaceFileExtension(state.dataStrGlobals->outDirPath / state.dataStrGlobals->inputFilePathNameOnly, ".epJSON"));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actual fix...

@Myoldmopar
Copy link
Member

Oopsie. OK, thanks, merging.

@Myoldmopar Myoldmopar merged commit d5b1f6e into develop Aug 30, 2021
@Myoldmopar Myoldmopar deleted the 9022_convertOnlyPath branch August 30, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

energyplus --convert / --convert-only doesn't take output dir path correctly
6 participants