Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from 24 bit to 20 bit caching for PsyTsatFnPb when using PerformancePrecisionTradeoffs Mode06 or higher #9024

Merged
merged 8 commits into from
Sep 3, 2021

Conversation

JasonGlazer
Copy link
Contributor

Pull request overview

A continuation of #8946 related to using cubic spline interpolation for the PsyTsatFnPb function. This changes the number of bits used for the caching from 24 to 20 bits which should result in faster execution time.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@JasonGlazer JasonGlazer added the NewFeature Includes code to add a new feature to EnergyPlus label Aug 30, 2021
@JasonGlazer JasonGlazer self-assigned this Aug 30, 2021
@mjwitte
Copy link
Contributor

mjwitte commented Sep 3, 2021

Ran regressions locally (no diffs for all files with design days, no diffs for 20 random files with annuals), unit test are running, so far, so good.

@mjwitte
Copy link
Contributor

mjwitte commented Sep 3, 2021

Unit tests pass, run a sample file with modes 5-8, no crashes, merging.

@mjwitte mjwitte merged commit e441723 into develop Sep 3, 2021
@mjwitte mjwitte deleted the tsatprecisions20 branch September 3, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Includes code to add a new feature to EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants