-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversion to enum class - DataPlant::PlantEquipmentType #9053
Conversation
…array, error message using format()
…ormation before refactoring. This reverts commit ed36c88.
Major set of changes here, CI was all clean the last time it ran. I'm pulling in develop and we'll let CI re-run. I'll look over the changes. Otherwise are there known remaining tasks here? |
@Myoldmopar nothing as part of this PR. Will continue shaving related yaks in future passes. |
Fantastic! I pulled in develop, ran all tests, including regressions, and everything is all green as expected. Merging this one. |
Thank you! 🎉 |
Clean up for PR: conv to enum DataPlant::PlantEquipmentType #9053
Conversion to enum class - DataPlant::PlantEquipmentType
Clean up for PR: conv to enum DataPlant::PlantEquipmentType #9053
Pull request overview
if-else
toswitch/case
conversions.Legend for comments:
👍🏽 - completed
🚀 - To be done later. To-do list link.
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.