Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion to enum class - DataPlant::PlantEquipmentType #9053

Merged
merged 141 commits into from
Nov 2, 2021

Conversation

jmythms
Copy link
Contributor

@jmythms jmythms commented Sep 10, 2021

Pull request overview

  • This PR converts the constexpr int to an enum class: PlantEquipmentType.
  • Fixes a CurOpSchemeType bug.
  • Converts OpScheme from enum to enum class
  • Changed getEnumerationValue to be case sensitive.
  • A lot of if-else to switch/case conversions.

Legend for comments:
👍🏽 - completed
🚀 - To be done later. To-do list link.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jmythms jmythms marked this pull request as ready for review October 9, 2021 04:52
@Myoldmopar
Copy link
Member

Major set of changes here, CI was all clean the last time it ran. I'm pulling in develop and we'll let CI re-run. I'll look over the changes. Otherwise are there known remaining tasks here?

@amirroth
Copy link
Collaborator

amirroth commented Nov 2, 2021

@Myoldmopar nothing as part of this PR. Will continue shaving related yaks in future passes.

@Myoldmopar
Copy link
Member

Fantastic! I pulled in develop, ran all tests, including regressions, and everything is all green as expected. Merging this one.

@Myoldmopar Myoldmopar merged commit f355562 into develop Nov 2, 2021
@Myoldmopar Myoldmopar deleted the enumsDataPlant branch November 2, 2021 19:24
@jmythms
Copy link
Contributor Author

jmythms commented Nov 2, 2021

Thank you! 🎉

Myoldmopar added a commit that referenced this pull request Nov 29, 2021
Clean up for PR: conv to enum DataPlant::PlantEquipmentType #9053
yujiex pushed a commit that referenced this pull request Jan 27, 2022
Conversion to enum class - DataPlant::PlantEquipmentType
yujiex pushed a commit that referenced this pull request Jan 27, 2022
Clean up for PR: conv to enum DataPlant::PlantEquipmentType #9053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants