Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post release I/O changes of the simple glazing frame feature #9117

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Post release I/O changes of the simple glazing frame feature #9117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f16ee7
post release io changes
xuanluo113 Oct 4, 2021
d4c20e3
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into sim…
xuanluo113 Oct 14, 2021
f000860
Merge branch 'develop' of https://github.com/NREL/EnergyPlus into sim…
xuanluo113 Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions idd/Energy+.idd.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5129,10 +5129,8 @@ WindowMaterial:SimpleGlazingSystem,
N1 , \field U-Factor
\required-field
\note Enter U-Factor including film coefficients
\note Note that the effective upper limit for U-factor is 5.8 W/m2-K
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I know this was discussed in the other PR; this is a good change.

\units W/m2-K
\minimum> 0
\maximum 7
N2 , \field Solar Heat Gain Coefficient
\required-field
\note SHGC at Normal Incidence
Expand Down
24 changes: 4 additions & 20 deletions src/EnergyPlus/WindowManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7365,14 +7365,9 @@ namespace WindowManager {
// Write Descriptions
print(state.files.eio,
"{}\n",
"! <WindowConstruction>,Construction Name,Index,#Layers,Roughness,Conductance {W/m2-K},SHGC,"
"! <WindowConstruction>,Construction Name,Index,#Layers,Roughness,Conductance {W/m2-K},Conductance (Before Adjusted) {W/m2-K},"
"Convection Coefficient Adjustment Ratio,SHGC,"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added new fields to the EIO, again just held off for I/O freeze. 👍

"Solar Transmittance at Normal Incidence,Visible Transmittance at Normal Incidence");
// todo - hold off for bug fix release
// print(state.files.eio,
// "{}\n",
// "! <WindowConstruction>,Construction Name,Index,#Layers,Roughness,Conductance {W/m2-K},Conductance (Before Adjusted)
// {W/m2-K}," "Convection Coefficient Adjustment Ratio,SHGC," "Solar Transmittance at Normal Incidence,Visible
// Transmittance at Normal Incidence");
if ((state.dataHeatBal->TotSimpleWindow > 0) || (state.dataHeatBal->W5GlsMat > 0) || (state.dataHeatBal->W5GlsMatAlt > 0))
print(state.files.eio,
"{}\n",
Expand Down Expand Up @@ -7539,22 +7534,11 @@ namespace WindowManager {
state.dataConstruction->Construct(ThisNum).TotLayers,
Roughness(static_cast<int>(state.dataConstruction->Construct(ThisNum).OutsideRoughness)),
NominalConductanceWinter,
state.dataHeatBal->NominalUBeforeAdjusted(ThisNum),
state.dataHeatBal->CoeffAdjRatio(ThisNum),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the 2 new fields are added here 👍

SHGCSummer,
TransSolNorm,
TransVisNorm);
// todo
// print(state.files.eio,
// Format_700,
// state.dataConstruction->Construct(ThisNum).Name,
// ThisNum,
// state.dataConstruction->Construct(ThisNum).TotLayers,
// Roughness(static_cast<int>(state.dataConstruction->Construct(ThisNum).OutsideRoughness)),
// NominalConductanceWinter,
// state.dataHeatBal->NominalUBeforeAdjusted(ThisNum),
// state.dataHeatBal->CoeffAdjRatio(ThisNum),
// SHGCSummer,
// TransSolNorm,
// TransVisNorm);
}
// Write(OutputFileConstrainParams, 705) TRIM(Construct(ThisNum)%Name), SHGCSummer ,TransVisNorm

Expand Down