Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 9215 central heat pump schedule #9226

Merged
merged 11 commits into from
Jan 15, 2022
Merged

Fix 9215 central heat pump schedule #9226

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8cfce1e
Deal with situation when the control schedule was not found.
jcyuan2020 Jan 5, 2022
fd5e912
Add warning messages about the problem and informing the default trea…
jcyuan2020 Jan 5, 2022
de22cef
unit test iteration 1 calling the factory to call the target function…
jcyuan2020 Jan 5, 2022
b9b14cd
Added the chiller pieces to the unit test; some more elements about t…
jcyuan2020 Jan 5, 2022
d192fda
Unit test fail on a child object processing which is not so relevant.
jcyuan2020 Jan 5, 2022
752e801
Unit test and another fatal error letting the unit test down.
jcyuan2020 Jan 5, 2022
b4062cc
Unit test went through successfully.
jcyuan2020 Jan 5, 2022
bc50706
clang formatting.
jcyuan2020 Jan 5, 2022
a68190c
Unit test direct all the input processing function instead of calling…
jcyuan2020 Jan 7, 2022
7d70264
Some minor case adjustment in the unit test to make it clearer to dem…
jcyuan2020 Jan 7, 2022
30ded0e
Merge remote-tracking branch 'upstream/develop' into fix_9215_central…
jcyuan2020 Jan 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/EnergyPlus/PlantCentralGSHP.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,6 +705,16 @@ void GetWrapperInput(EnergyPlusData &state)
} else {
state.dataPlantCentralGSHP->Wrapper(WrapperNum).WrapperComp(Comp).CHSchedPtr =
ScheduleManager::GetScheduleIndex(state, state.dataIPShortCut->cAlphaArgs(loop + 2));
if (state.dataPlantCentralGSHP->Wrapper(WrapperNum).WrapperComp(Comp).CHSchedPtr == 0) {
state.dataPlantCentralGSHP->Wrapper(WrapperNum).WrapperComp(Comp).CHSchedPtr = DataGlobalConstants::ScheduleAlwaysOn;
ShowWarningError(state, "Chiller Heater Modules Control Schedule Name not found");
ShowContinueError(state,
" for " + state.dataPlantCentralGSHP->Wrapper(WrapperNum).WrapperComp(Comp).WrapperPerformanceObjectType +
"= " + state.dataPlantCentralGSHP->Wrapper(WrapperNum).WrapperComp(Comp).WrapperComponentName);
ShowContinueError(
state, " in the object " + state.dataIPShortCut->cCurrentModuleObject + "= " + state.dataIPShortCut->cAlphaArgs(1));
ShowContinueError(state, "The Control Schedule is treated as AlwaysOn instead.");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is fine with me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! The changes have been pushed, waiting for the ci results.

}
state.dataPlantCentralGSHP->Wrapper(WrapperNum).WrapperComp(Comp).WrapperIdenticalObjectNum =
state.dataIPShortCut->rNumericArgs(1 + Comp);
Expand Down
153 changes: 153 additions & 0 deletions tst/EnergyPlus/unit/PlantCentralGSHP.unit.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,3 +200,156 @@ TEST_F(EnergyPlusFixture, ChillerHeater_Autosize)
Real64 RefCOPClgHtgExpected = RefCapClgHtgExpected / RefPowerClgHtgExpected;
EXPECT_DOUBLE_EQ(RefCOPClgHtgExpected, state->dataPlantCentralGSHP->Wrapper(1).ChillerHeater(1).RefCOPClgHtg);
}

TEST_F(EnergyPlusFixture, Test_CentralHeatPumpSystem_Control_Schedule_fix)
{
std::string const idf_objects = delimited_string(
{"CentralHeatPumpSystem,",
"ChW_Loop HeatPump1, !-Name",
"SmartMixing, !-Control Method",
"ChW_Loop HeatPump1 ChW Inlet, !-Cooling Loop Inlet Node Name",
"ChW_Loop HeatPump1 ChW Outlet, !-Cooling Loop Outlet Node Name",
"ChW_Loop HeatPump1 Cnd Inlet, !-Source Loop Inlet Node Name",
"ChW_Loop HeatPump1 Cnd Outlet, !-Source Loop Outlet Node Name",
"ChW_Loop HeatPump1 HHW Inlet, !-Heating Loop Inlet Node Name",
"ChW_Loop HeatPump1 HHW Outlet, !-Heating Loop Outlet Node Name",
"460, !-Ancillary Power{W}",
", !-Ancillary Operation Schedule Name",
"ChillerHeaterPerformance:Electric:EIR, !-Chiller Heater Modules Performance Component Object Type 1",
"ChW_Loop HeatPump1 Module, !-Chiller Heater Modules Performance Component Name 1",
"Always1, !-Chiller Heater Modules Control Schedule Name 1",
"2; !-Number of Chiller Heater Modules 1",

"ChillerHeaterPerformance:Electric:EIR,",
" ChW_Loop HeatPump1 Module, !- Name",
" autosize, !- Reference Cooling Mode Evaporator Capacity {W}",
" 1.5, !- Reference Cooling Mode COP {W/W}",
" 6.67, !- Reference Cooling Mode Leaving Chilled Water Temperature {C}",
" 29.4, !- Reference Cooling Mode Entering Condenser Fluid Temperature {C}",
" 35.0, !- Reference Cooling Mode Leaving Condenser Water Temperature {C}",
" 0.74, !- Reference Heating Mode Cooling Capacity Ratio",
" 0.925, !- Reference Heating Mode Cooling Power Input Ratio",
" 6.67, !- Reference Heating Mode Leaving Chilled Water Temperature {C}",
" 60, !- Reference Heating Mode Leaving Condenser Water Temperature {C}",
" 29.4, !- Reference Heating Mode Entering Condenser Fluid Temperature {C}",
" 5, !- Heating Mode Entering Chilled Water Temperature Low Limit {C}",
" VariableFlow, !- Chilled Water Flow Mode Type",
" autosize, !- Design Chilled Water Flow Rate {m3/s}",
" autosize, !- Design Condenser Water Flow Rate {m3/s}",
" 0.01684, !- Design Hot Water Flow Rate {m3/s}",
" 1, !- Compressor Motor Efficiency",
" WaterCooled, !- Condenser Type",
" EnteringCondenser, !- Cooling Mode Temperature Curve Condenser Water Independent Variable",
" ChillerHeaterClgCapFT, !- Cooling Mode Cooling Capacity Function of Temperature Curve Name",
" ChillerHeaterClgEIRFT, !- Cooling Mode Electric Input to Cooling Output Ratio Function of Temperature Curve Name",
" ChillerHeaterClgEIRFPLR, !- Cooling Mode Electric Input to Cooling Output Ratio Function of Part Load Ratio Curve Name",
" 1, !- Cooling Mode Cooling Capacity Optimum Part Load Ratio",
" LeavingCondenser, !- Heating Mode Temperature Curve Condenser Water Independent Variable",
" ChillerHeaterHtgCapFT, !- Heating Mode Cooling Capacity Function of Temperature Curve Name",
" ChillerHeaterHtgEIRFT, !- Heating Mode Electric Input to Cooling Output Ratio Function of Temperature Curve Name",
" ChillerHeaterHtgEIRFPLR, !- Heating Mode Electric Input to Cooling Output Ratio Function of Part Load Ratio Curve Name",
" 1, !- Heating Mode Cooling Capacity Optimum Part Load Ratio",
" 1; !- Sizing Factor",

"Curve:Biquadratic,",
" ChillerHeaterClgCapFT, !- Name",
" 0.950829, !- Coefficient1 Constant",
" 3.419327E-02, !- Coefficient2 x",
" 2.66642E-04, !- Coefficient3 x**2",
" -1.733397E-03, !- Coefficient4 y",
" -1.762417E-04, !- Coefficient5 y**2",
" -3.69198E-05, !- Coefficient6 x*y",
" 4.44, !- Minimum Value of x",
" 12.78, !- Maximum Value of x",
" 12.78, !- Minimum Value of y",
" 29.44, !- Maximum Value of y",
" , !- Minimum Curve Output",
" , !- Maximum Curve Output",
" Temperature, !- Input Unit Type for X",
" Temperature, !- Input Unit Type for Y",
" Dimensionless; !- Output Unit Type",

"Curve:Biquadratic,",
" ChillerHeaterHtgCapFT, !- Name",
" 0.9415266, !- Coefficient1 Constant",
" 5.527431E-02, !- Coefficient2 x",
" 3.573558E-04, !- Coefficient3 x**2",
" 1.258391E-03, !- Coefficient4 y",
" -6.420546E-05, !- Coefficient5 y**2",
" -5.350989E-04, !- Coefficient6 x*y",
" 4.44, !- Minimum Value of x",
" 15.56, !- Maximum Value of x",
" 35, !- Minimum Value of y",
" 57.22, !- Maximum Value of y",
" , !- Minimum Curve Output",
" , !- Maximum Curve Output",
" Temperature, !- Input Unit Type for X",
" Temperature, !- Input Unit Type for Y",
" Dimensionless; !- Output Unit Type",

"Curve:Biquadratic,",
" ChillerHeaterClgEIRFT, !- Name",
" 0.7362431, !- Coefficient1 Constant",
" 2.136491E-02, !- Coefficient2 x",
" 3.638909E-04, !- Coefficient3 x**2",
" -4.284947E-03, !- Coefficient4 y",
" 3.389817E-04, !- Coefficient5 y**2",
" -3.632396E-04, !- Coefficient6 x*y",
" 4.44, !- Minimum Value of x",
" 12.78, !- Maximum Value of x",
" 12.78, !- Minimum Value of y",
" 29.44, !- Maximum Value of y",
" , !- Minimum Curve Output",
" , !- Maximum Curve Output",
" Temperature, !- Input Unit Type for X",
" Temperature, !- Input Unit Type for Y",
" Dimensionless; !- Output Unit Type",

"Curve:Biquadratic,",
" ChillerHeaterHtgEIRFT, !- Name",
" 0.2286246, !- Coefficient1 Constant",
" 2.498714E-02, !- Coefficient2 x",
" -1.267106E-05, !- Coefficient3 x**2",
" 9.327184E-03, !- Coefficient4 y",
" 5.892037E-05, !- Coefficient5 y**2",
" -3.268512E-04, !- Coefficient6 x*y",
" 4.44, !- Minimum Value of x",
" 15.56, !- Maximum Value of x",
" 35.0, !- Minimum Value of y",
" 57.22, !- Maximum Value of y",
" , !- Minimum Curve Output",
" , !- Maximum Curve Output",
" Temperature, !- Input Unit Type for X",
" Temperature, !- Input Unit Type for Y",
" Dimensionless; !- Output Unit Type",

" Curve:Cubic,",
" ChillerHeaterClgEIRFPLR, !- Name",
" 0.0, !- Coefficient1 Constant",
" 1.22895, !- Coefficient2 x",
" -0.751383, !- Coefficient3 x**2",
" 0.517396, !- Coefficient4 x**3",
" 0.2, !- Minimum Value of x",
" 1; !- Maximum Value of x",

"Curve:Cubic,",
" ChillerHeaterHtgEIRFPLR, !- Name",
" 0.0, !- Coefficient1 Constant",
" 1.12853, !- Coefficient2 x",
" -0.0264962, !- Coefficient3 x**2",
" -0.103811, !- Coefficient4 x**3",
" 0.3, !- Minimum Value of x",
" 1; !- Maximum Value of x"

});

ASSERT_TRUE(process_idf(idf_objects));

// call the factory with a valid name to trigger reading inputs
state->dataPlantCentralGSHP->getWrapperInputFlag = true;

auto compPtr = PlantCentralGSHP::WrapperSpecs::factory(*state, "CHW_LOOP HEATPUMP1");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This compPtr is unused and throwing a warning from the compiler. I'm guessing you probably don't need to call the PlantComponent wrapper function anyway though, and instead just call the GetWrapperInput function instead (which the factory probably does anyway...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defect file added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is also done now. It calling the "GetWrapperInput()' function directly, with some minor changes in the idf snippet, e.g. added a schedule.


// verify that under this scenario of not finding a schedule match, ScheduleAlwaysOn is the treated default
EXPECT_EQ(state->dataPlantCentralGSHP->Wrapper(1).WrapperComp(1).CHSchedPtr, DataGlobalConstants::ScheduleAlwaysOn);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable assertion for the unit test 👍

}