Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heat pump detailed performance inputs #1317

Merged
merged 230 commits into from
Nov 13, 2023
Merged

Heat pump detailed performance inputs #1317

merged 230 commits into from
Nov 13, 2023

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Mar 13, 2023 •
edited
Loading

Pull Request Description

Updated assumptions for variable-speed air conditioners, heat pumps, and mini-splits.

Also allows detailed heating and cooling performance data (min/max COPs and capacities at different outdoor temperatures) as an optional set of inputs. Data can be sourced from e.g. NEEP's Cold Climate Air Source Heat Pump List.

Closes #1028 and closes #1341. Takes advantage of hpxmlwg/hpxml#359.

TODO:

  • Replace existing curve objects with Energyplus lookup table (maybe we can find cutler curve and directly use those data; Or we need to determine the sample size for granularity)
  • Implement net to gross capacity conversion
  • Use Energyplus lookup table to implement detailed performance inputs
  • Consolidate with capacity retention inputs
  • Default performance curves from NEEP database
    • Rated COP from hspf and seer for all speeds, to determine for each speed we either can use different regressions (preferred) or use a ratio
    • Rated capacities for all speeds
  • Deprecate old performance-related methods
  • HVAC autosizing under different scenarios

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests and/or workflow/tests/hpxml_translator_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Mar 13, 2023
shorowit and others added 4 commits March 13, 2023 15:08
@shorowit
Bugfix.
41efcfd
@shorowit
Bugfix.
44ed0db
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
b4bf80c 
…o heat_pump_detailed_performance

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
Latest results.
0f45b67
@shorowit shorowit added the enhancement New feature or request label Mar 16, 2023
shorowit and others added 7 commits April 11, 2023 10:43
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
515b64d 
…o heat_pump_detailed_performance

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	tasks.rb
#	workflow/tests/base_results/results.csv
#	workflow/tests/base_results/results_bills.csv
@shorowit
update_measures
d69dd9b
Latest results.
63f1cf7
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
01edbcc 
…o heat_pump_detailed_performance
Latest results.
f8d72f4
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
e66bd05 
…o heat_pump_detailed_performance
Latest results.
d93bc6e
@shorowit shorowit added this to the 1.6.1 milestone May 2, 2023
shorowit and others added 3 commits May 3, 2023 16:38
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
fdd1894 
…o heat_pump_detailed_performance

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	workflow/hpxml_inputs.tsv
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
88f279d 
…o heat_pump_detailed_performance
@yzhou601
first cut for table lookup, not completed
29d3eca
@shorowit shorowit mentioned this pull request May 10, 2023
Merged
7 tasks
shorowit and others added 3 commits May 10, 2023 16:36
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
ebe2538 
…o heat_pump_detailed_performance

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	workflow/tests/base_results/results.csv
#	workflow/tests/base_results/results_bills.csv
@shorowit
Drop support for CapacityFractionOfNominal elements; lets keep things…
d93d8b9 
… simple for the initial implementation.
Latest results.
280ed36
@shorowit shorowit removed their assignment May 12, 2023
yzhou601 and others added 7 commits October 24, 2023 11:50
@yzhou601
add nominal speed in sizing, restore get_sizing_speed
9ece063
@yzhou601
update_measures
766132a
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
bd656f9 
…o heat_pump_detailed_performance
@shorowit
Fix GSHP test failures and cleanup code.
e05e322
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
609f2d3 
…o heat_pump_detailed_performance

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/resources/weather.rb
#	workflow/tests/base_results/results.csv
#	workflow/tests/base_results/results_bills.csv
#	workflow/tests/base_results/results_sizing.csv
@shorowit
Bugfix.
c7d71f7
Latest results.
3e23593
@shorowit shorowit mentioned this pull request Oct 26, 2023
Closed
8 tasks
@shorowit
Copy link
Contributor Author

shorowit commented Oct 31, 2023 •
edited
Loading

TODO:

  • Make sure default fanspeed/capacity ratios are not used when detailed performance inputs provided @yzhou601
  • Add more unit tests, particularly around HVAC installation quality @yzhou601 @shorowit

yzhou601 and others added 13 commits October 31, 2023 15:59
@yzhou601
fan_speed_ratio and capacity ratio override
a8a4c13
@yzhou601
Merge branch 'heat_pump_detailed_performance' of https://github.com/N…
aeb696f 
…REL/OpenStudio-HPXML into heat_pump_detailed_performance
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
57c6489 
…o heat_pump_detailed_performance
Latest results.
939d869
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
b55b4d7 
…o heat_pump_detailed_performance

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.rb
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/resources/hpxml.rb
#	HPXMLtoOpenStudio/resources/hpxml_defaults.rb
#	HPXMLtoOpenStudio/resources/hvac.rb
#	HPXMLtoOpenStudio/resources/hvac_sizing.rb
#	HPXMLtoOpenStudio/tests/test_defaults.rb
#	HPXMLtoOpenStudio/tests/test_hvac.rb
#	HPXMLtoOpenStudio/tests/test_hvac_sizing.rb
#	HPXMLtoOpenStudio/tests/test_validation.rb
#	tasks.rb
#	workflow/tests/base_results/results.csv
#	workflow/tests/base_results/results_bills.csv
#	workflow/tests/base_results/results_sizing.csv
Latest results.
63caade
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
218dba3 
…o heat_pump_detailed_performance

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/resources/weather.rb
#	workflow/tests/base_results/results_sample_files.csv
#	workflow/tests/base_results/results_sample_files_bills.csv
Latest results.
d934869
@shorowit
Update tests and misc cleanup.
080a843
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
8c77d59 
…o heat_pump_detailed_performance

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/resources/hvac_sizing.rb
#	workflow/tests/base_results/results_real_homes.csv
#	workflow/tests/base_results/results_real_homes_bills.csv
#	workflow/tests/base_results/results_sample_files_bills.csv
#	workflow/tests/base_results/results_sizing.csv
#	workflow/tests/base_results/results_workflow_simulations1.csv
@shorowit
Use sizing speed more places in hvac_sizing.rb. Update tests.
455a0d7
Latest results.
adc2d8f
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
983a79d 
…o heat_pump_detailed_performance

# Conflicts:
#	BuildResidentialHPXML/README.md
#	BuildResidentialHPXML/measure.rb
#	BuildResidentialHPXML/measure.xml
#	Changelog.md
#	HPXMLtoOpenStudio/measure.xml
#	docs/source/workflow_inputs.rst
#	workflow/tests/base_results/results_workflow_simulations1.csv
#	workflow/tests/base_results/results_workflow_simulations1_bills.csv
@shorowit shorowit marked this pull request as ready for review November 13, 2023 20:11
@shorowit shorowit merged commit d741ae7 into master Nov 13, 2023
@shorowit shorowit deleted the heat_pump_detailed_performance branch November 13, 2023 21:03
@joseph-robertson joseph-robertson mentioned this pull request Nov 21, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhou601 yzhou601 yzhou601 left review comments

Assignees

@yzhou601 yzhou601

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Replace performance curves w/ TableLookup? Allow NEEP ccASHP inputs for variable-speed heat pumps
2 participants
@shorowit @yzhou601