Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of hourly msgpack file #1542

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix use of hourly msgpack file #1542

merged 1 commit into from
Nov 7, 2023

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Nov 6, 2023

Pull Request Description

Hit this error in a BEopt test now that most of our end uses are derived from Output:Meters instead of Output:Variables as a result of #1456. One can replicate the issue by having no hourly Output:Variable requests (e.g., remove any HVAC systems) but request emissions calculations (which require hourly data).

Test file:
test.xml

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

…at most of our end uses are derived from Output:Meters instead of Output:Variables.
@shorowit shorowit added the bug label Nov 6, 2023
@shorowit shorowit merged commit 5aef27a into master Nov 7, 2023
@shorowit shorowit deleted the fix_msgpack_hourly branch November 7, 2023 03:14
@joseph-robertson joseph-robertson mentioned this pull request Nov 8, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant