Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test OS 3.7.0-rc3 #1545

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Test OS 3.7.0-rc3 #1545

merged 6 commits into from
Nov 17, 2023

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Nov 8, 2023

Pull Request Description

[description here]

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Nov 8, 2023
@shorowit
Copy link
Contributor Author

shorowit commented Nov 8, 2023

All the remaining CI failures are caused by two OpenStudio issues:

  1. No results.json is produced after running an OSW.
  2. The reporting measure warnings are not making their way into the run.log.

…o os370rc2

# Conflicts:
#	ReportSimulationOutput/measure.xml
#	ReportUtilityBills/measure.xml

[ci skip]
@shorowit shorowit changed the title Test OS 3.7.0-rc2 Test OS 3.7.0-rc3 Nov 16, 2023
@shorowit shorowit marked this pull request as ready for review November 17, 2023 16:15
@shorowit shorowit merged commit 8db786f into master Nov 17, 2023
6 checks passed
@shorowit shorowit deleted the os370rc2 branch November 17, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant