Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document airflow.rb #1905

Merged
merged 18 commits into from
Jan 3, 2025
Merged

Document airflow.rb #1905

merged 18 commits into from
Jan 3, 2025

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Dec 28, 2024 •
edited
Loading

Pull Request Description

Addresses #1759. Adds ruby documentation to airflow.rb and some light code refactor.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Dec 28, 2024
shorowit and others added 16 commits December 27, 2024 18:39
@shorowit
Use a constant.
9f13cda
@shorowit
Fix comment
55fb654
Latest results.
ad7675e
@shorowit
Merge branch 'airflow_rb_doc' of https://github.com/NREL/OpenStudio-H…
ae6bf1d 
…PXML into airflow_rb_doc
@shorowit
Address regression.
2490ba1
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
892657a 
…o airflow_rb_doc

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
Latest results.
160b18b
@shorowit
Remove Airflow::Duct class and some refactoring.
b3ab043
@shorowit
Merge branch 'airflow_rb_doc' of https://github.com/NREL/OpenStudio-H…
6f8b8ca 
…PXML into airflow_rb_doc
@shorowit
Fix CI failure, finish code documentation.
0729338
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
7be36df 
…o airflow_rb_doc

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
@shorowit
Minor cleanup.
8807d19
@shorowit
Bugfix.
5b425ef
@shorowit
Revert to original approach for garage height.
2e4ed56
Latest results.
7ad2760
@shorowit
Update comment [ci skip]
749cd8a
@shorowit shorowit marked this pull request as ready for review January 3, 2025 03:28
@shorowit shorowit merged commit 2efcd6b into master Jan 3, 2025
@shorowit shorowit deleted the airflow_rb_doc branch January 3, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
documentation refactor
Projects
OpenStudio-HPXML
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shorowit