Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle enablement for Oscli PR #381

Merged
merged 4 commits into from
Aug 8, 2018
Merged

Bundle enablement for Oscli PR #381

merged 4 commits into from
Aug 8, 2018

Conversation

rHorsey
Copy link
Contributor

@rHorsey rHorsey commented Aug 7, 2018

This PR will allow for gems to be swapped using the OpenStudio CLI features enabled in the 270-241-develop branch and workflow initialization scripts. This is blocked by NREL/docker-openstudio#31

@rHorsey
Copy link
Contributor Author

rHorsey commented Aug 7, 2018

@nllong and @anyaelena ready for review - I'm particularly unsure about _${OS_BUNDLER_VERSION}_ addition in the server Dockerfile - should we be using 1.14.4 for this? If not, should we explicitly be using something else?

Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I'm eager to test the new docker openstudio containers.

@@ -9,5 +9,5 @@ vagrant
/server/spec/runs.txt
/server/spec/files/tmp/
/server/spec/files/test_model/tmp_run_single
/spec/unit-test
/spec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.933% when pulling 7a2a989 on smartds into 2606aca on 270-241-develop.

@rHorsey rHorsey merged commit e5b2141 into 270-241-develop Aug 8, 2018
@rHorsey rHorsey deleted the smartds branch August 8, 2018 23:32
@anyaelena anyaelena changed the title Bundle enablement for oscli PR Bundle enablement for Oscli PR Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants