Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage roo and bundler versions #454

Merged
merged 3 commits into from
Jan 21, 2019
Merged

manage roo and bundler versions #454

merged 3 commits into from
Jan 21, 2019

Conversation

anyaelena
Copy link
Member

Roo 2.8.0 released 1/18/2019 drops Ruby 2.2 support.

@nllong
Copy link
Member

nllong commented Jan 21, 2019

@anyaelena this also hit @kflemin this morning.

…. Bundler 2 is not compatible with Ruby 2.2.
@anyaelena anyaelena changed the title manage roo version. manage roo and bundler versions Jan 21, 2019
@anyaelena anyaelena requested a review from nllong January 21, 2019 22:18
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a PR to fix the original issue with roo here (NREL/OpenStudio-analysis-gem#33). It isn't passing due to some bundler version issue which I haven't had time to address. Regardless, it is nice to have the constraints in here.

@anyaelena anyaelena merged commit 67f705e into develop Jan 21, 2019
@anyaelena anyaelena deleted the version-fix branch January 22, 2019 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants